Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: no halting 🚀 #178

Merged
merged 8 commits into from
Nov 17, 2022
Merged

chore: no halting 🚀 #178

merged 8 commits into from
Nov 17, 2022

Conversation

bryanchriswhite
Copy link

@bryanchriswhite bryanchriswhite commented Nov 16, 2022

Changes

  • add UnprocessedEntity entity to track details of a failure while during handling
  • add misc. utils to simplify impact on handler code
  • refactor existing handlers to use track unprocessed entities and continue running in the event of an error

@bryanchriswhite bryanchriswhite self-assigned this Nov 16, 2022
@bryanchriswhite bryanchriswhite linked an issue Nov 16, 2022 that may be closed by this pull request
Jonathansumner
Jonathansumner previously approved these changes Nov 17, 2022
Copy link
Member

@Jonathansumner Jonathansumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Bryan, really nice work!

@bryanchriswhite bryanchriswhite merged commit 3b4bbf3 into main Nov 17, 2022
@bryanchriswhite bryanchriswhite deleted the chore/no-halting branch November 17, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Halt prevention
2 participants