This repository has been archived by the owner on Dec 5, 2022. It is now read-only.
Use provisioner type attribute #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vagrant changed the provisioner name attribute to type in version 1.7.1.
|
Would be great to see that merged! |
|
Thanks and sorry it took so long! The 1.2.0 version of the plugin will come out with this in a few ;-) |
| @@ -6,7 +6,7 @@ module ChefFileCachePath | |||
| def self.chef_provisioner?(machine) | |||
| provisioners = machine.config.vm.provisioners | |||
| chef_provisioners = [:chef_solo, :chef_client] | |||
| compat_provisioners = provisioners.keep_if { |p| chef_provisioners.include? p.name } | |||
| compat_provisioners = provisioners.keep_if { |p| chef_provisioners.include? p.name || p.type } | |||
There was a problem hiding this comment.
@fgrehm @Yserz that might be a bit too optimistic and works only if the provisioner name is not set. However, note that you can have named provisioners in which case the p.name might be anything:
https://docs.vagrantup.com/v2/provisioning/basic_usage.html
Here's how I solved it in one of my vagrant plugins:
tknerr/vagrant-toplevel-cookbooks@ae188ee
Or @sethvargo here:
https://github.com/berkshelf/vagrant-berkshelf/blob/cd5ee78f28ee9f6bec1b72fcdbcb042b0155aa04/lib/vagrant-berkshelf/helpers.rb#L69-L86
/cc @cassianoleal
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vagrant changed the provisioner name attribute to type in version 1.7.1.
fixes #133