feat(actions): upgrade the goreleaser step to version 5, and setup-go version to 1.22 #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… version to 1.22 This change is needed to fix the depracted message 'DEPRECATED: brews.folder should not be used anymore, check https://goreleaser.com/deprecations#brewsfolder for more info', and to fix the issue 'unknown directive: toolchain' which is introduced, because we upgraded the source code to use go1.22, but not the GitHub Action Signed-off-by: Casale, Robert <[email protected]>
Gearheads
requested review from
rajarajanpsj,
kishoregv,
niroowns,
awatterson22,
felixdeleon and
gseshagirirao
as code owners
This change will hopefully fix the error message within the pr-title-action, 'Error: require() of ES Module /action/node_modules/conventional-changelog-angular/src/index.js from /action/src/validateTitle.js not supported.' Signed-off-by: Casale, Robert <[email protected]>
This change will pin the version of conventional-changelog-angular instead of using the latest version, which changed their packages to ESM-only. I believe the ESM-only packages causes the issue of require() not being supported. Signed-off-by: Casale, Robert <[email protected]>
Gearheads
force-pushed
the
feature/goreleaser-upgrade
branch
from
4b762fe
to
815b0a1
Compare
awatterson22
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change is needed to fix the deprecated message
'DEPRECATED: brews.folder should not be used anymore, check https://goreleaser.com/deprecations#brewsfolder for more info', and to fix the issue'unknown directive: toolchain'which is introduced, because we upgraded the source code to use go1.22, but not the GitHub ActionWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes # https://github.com/fidelity/kconnect/actions/runs/8986941097/job/24684255990
Testing
Enabled the
pull_requesttrigger to test the GitHub action changes before merging to themainbranch, and the GitHub action changes completed successfully:This branch can be deleted once it is merged.