Checked compat with JNA 5.11.0 #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mkitti Uh oh, I just noticed this. Now that we've upgraded Fiji to JNA 5.12.1, but not merged this PR... are there problems with SPIM_Registration? Shall we rebase/update this PR and get it merged? |
|
Native.loadLibrary is deprecated and should be changed to Native.load. |
* Update scijava-pom to 33.0.0. * Checked compat with JNA 5.11.0. * Use Native.load rather than Native.loadLibrary. Signed-off-by: Curtis Rueden <[email protected]>
ctrueden
force-pushed
the
mkitti/jna_update_5_11_0
branch
from
9955bf8
to
0d501fd
Compare
@mkitti Noted. But it's just deprecation, not actual breakage, right? In any case, I rebased the PR, fixed the conflicts, and merged this. Let me know if an immediate release is needed or not. |
|
I do not think an immediate release is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update scijava-pom to 31.1.0
Checked compat with JNA 5.11.0
Use Native.load rather than Native.loadLibrary
xref: scijava/pom-scijava#163