Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReplicaInfo to fip-0090 #1000

Merged
merged 4 commits into from
May 9, 2024
Merged

Conversation

ZenGround0
Copy link
Contributor

Proposed SealerActor FIP #993 is needed to fully unlock SaaS functionality after landing FIP 0090.

To avoid an annoying method deprecation we're predicting the needs of the SealerActor in the NI porep params. This PR adds fields for specifying sealer actor id and sealer actor specified sector number to the NI porep method. The protocol should enforce that these values are constrained until the sealer actor fip arrives.

FIPS/fip-0090.md Outdated Show resolved Hide resolved
FIPS/fip-0090.md Outdated Show resolved Hide resolved
@jennijuju
Copy link
Member

PR 1000!

@ZenGround0 ZenGround0 force-pushed the fip-0090/future-proof-NI-porep-params branch from ab4a893 to 04c54c9 Compare May 2, 2024 19:22
Copy link
Member

@anorth anorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptual 👍 , but nits

FIPS/fip-0090.md Outdated Show resolved Hide resolved
FIPS/fip-0090.md Outdated Show resolved Hide resolved
FIPS/fip-0090.md Outdated Show resolved Hide resolved
@ZenGround0 ZenGround0 force-pushed the fip-0090/future-proof-NI-porep-params branch from 07eb724 to 6305cf5 Compare May 6, 2024 04:02
@jsoares jsoares merged commit cf26f06 into master May 9, 2024
1 check passed
@jsoares jsoares deleted the fip-0090/future-proof-NI-porep-params branch May 9, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants