-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIP: Filecoin Message Replay Protection #300
Conversation
included my comment in #301 |
Hey @q9f! Perhaps I missed the thread- can I ask why you closed this FIP? Do you no longer plan to work on it? |
It hasn't been accepted as a draft and I considered it no longer desired. |
I think this draft should be merged. The lack of replay protection becomes even more important with user-programmability and user wallets interacting directly with on-chain actors. |
@q9f as long as you don't disagree, I'm reopening this issue. It simply hadn't been merged because FIP editors hadn't been able to provide feedback yet. Oftentimes, PRs stay open until multiple rounds of revision have taken place. However, FIP editors have all been pretty heads-down on the FVM FIPs. Replay protection may not be an immediate priority, but it's still important. In general, we are quite capacity limited, and governance topics intentionally move quite slowly. If you have questions or want to push on us, please do so! But no need to close issues and PRs- if the idea wasn't viable, you would know. |
Ok, that's fine. Maybe, I just misunderstood the process. I thought assigning a number and merging a draft is a no-brainer. |
Discussion to: #301
Summary: Defines Filecoin chain identifiers and adds them to unsigned messages and signatures to prevent transactions to be replayed across different Filecoin networks.
Note: I'm new to Filecoin and might have missed something in the specification. Feel free to point to everything I should now.