FIP-0045: spec the token receiver hook payload schema #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anorth
requested review from
momack2,
arajasek,
jennijuju and
kaitlin-beegle
as code owners
misilva73
reviewed
Sep 9, 2022
| until the allocation's maximum term is reached. | ||
|
|
||
| Since new allocations are more valuable than existing ones, this proposal may incentivise | ||
| deal-focussed but capital- or capacity-constrained providers to let existing sectors expires |
There was a problem hiding this comment.
Suggested change
| deal-focussed but capital- or capacity-constrained providers to let existing sectors expires | |
| deal-focussed but capital- or capacity-constrained providers to let existing sectors expire |
misilva73
reviewed
Sep 9, 2022
| deal-focussed but capital- or capacity-constrained providers to let existing sectors expires | ||
| in order to re-use the associated pledge and hardware for newer allocations. | ||
|
|
||
| Storage providers may prefer deals associated with long data cap allocation terms to those with shorter expected terms. |
There was a problem hiding this comment.
I think this will only happen if FIP36 is introduced. And, in that case, the pledge will also be higher for longer-duration sectors. Thus, SPs with lower capital or more risk averse will prefer shorter sectors (and shorter deals)
misilva73
reviewed
Sep 9, 2022
| @@ -653,18 +714,6 @@ and may be claimed by a collection of data commitments spread across multiple se | |||
| Such an allocation would be far more gas efficient than the multiple per-sector deals | |||
| required for a large data set today. | |||
|
|
|||
| ### Support for FIP-0036 | |||
There was a problem hiding this comment.
Why is this section being removed? Is it no longer valid?
There was a problem hiding this comment.
Correct (mainly because the opt-in migration of existing sectors was removed).
kaitlin-beegle
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This complements #455, answering the remaining TODOs currently noted there.