Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIP-0082: SuperSnaps -- Adding Snarkpack for SnapsDeals #838

Merged
merged 11 commits into from
Dec 13, 2023

Conversation

cryptonemo
Copy link
Contributor

No description provided.

@cryptonemo
Copy link
Contributor Author

cc: @anorth and @Kubuxu

FIPS/fip-00xx.md Outdated Show resolved Hide resolved
FIPS/fip-00xx.md Outdated Show resolved Hide resolved
FIPS/fip-00xx.md Outdated Show resolved Hide resolved
FIPS/fip-00xx.md Outdated Show resolved Hide resolved
FIPS/fip-00xx.md Outdated Show resolved Hide resolved
FIPS/fip-00xx.md Outdated Show resolved Hide resolved
FIPS/fip-00xx.md Outdated Show resolved Hide resolved
FIPS/fip-00xx.md Outdated Show resolved Hide resolved
FIPS/fip-00xx.md Outdated Show resolved Hide resolved
FIPS/fip-00xx.md Outdated Show resolved Hide resolved
FIPS/fip-00xx.md Outdated Show resolved Hide resolved
FIPS/fip-00xx.md Outdated Show resolved Hide resolved
@jennijuju
Copy link
Member

one nit from an editor perspective + agree with anorth's title suggestion - otherwise the the draft lgtm

@LaurenSpiegel
Copy link

@AxCortesCubero , any comments?

@AxCortesCubero
Copy link
Contributor

@AxCortesCubero , any comments?

@LaurenSpiegel I'm sorry, can you clarify what is the question for me? Do you mean my thoughts on the Batch Balancer-like discussion above?

I would agree it seems the same motivation that there was at the time of implementing the batch balancer for Pre and Prove Commit seems to apply to this case: introduces a batching tool that makes gas usage for batches more efficient, but would need something like Batch Balancer to ensure this batching is only enabled when there is demand and it is needed. So a batch balancer seems reasonable (would have to carefully choose the parameters for a given goal).

What would be even better would be more permanent solutions like Explicit proof fees @Kubuxu has been leading, but this project has been somewhat paused. The best case scenario would be to finish carrying through the explicit fees idea, including this case.

FIPS/fip-00xx.md Outdated Show resolved Hide resolved
FIPS/fip-00xx.md Outdated Show resolved Hide resolved
FIPS/fip-00xx.md Outdated Show resolved Hide resolved
FIPS/fip-00xx.md Outdated Show resolved Hide resolved
Copy link
Member

@anorth anorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@anorth
Copy link
Member

anorth commented Dec 12, 2023

Assigning FIP-0082 to this. Please update the FIP metadata and filename, and add a link to this document in the root README.

@cryptonemo cryptonemo force-pushed the supersnaps branch 3 times, most recently from 9983e2f to df81f12 Compare December 12, 2023 01:13
@cryptonemo cryptonemo changed the title SuperSnaps: Adding Snarkpack for SnapsDeals FIP-0082: SuperSnaps -- Adding Snarkpack for SnapsDeals Dec 12, 2023
FIPS/fip-00xx.md Outdated Show resolved Hide resolved
FIPS/fip-0082.md Outdated Show resolved Hide resolved
FIPS/fip-0082.md Outdated Show resolved Hide resolved
FIPS/fip-0082.md Outdated Show resolved Hide resolved
FIPS/fip-0082.md Outdated Show resolved Hide resolved
FIPS/fip-0082.md Outdated Show resolved Hide resolved
FIPS/fip-0082.md Outdated Show resolved Hide resolved
FIPS/fip-0082.md Outdated Show resolved Hide resolved
FIPS/fip-0082.md Outdated Show resolved Hide resolved
@cryptonemo
Copy link
Contributor Author

Thanks for the approvals (all reviewers so far)! I'm unable to merge this, so I'll have to leave that to someone else if and when it's ready.

@jennijuju jennijuju merged commit 1b176ba into filecoin-project:master Dec 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants