-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIP-0082: SuperSnaps -- Adding Snarkpack for SnapsDeals #838
Conversation
one nit from an editor perspective + agree with anorth's title suggestion - otherwise the the draft lgtm |
@AxCortesCubero , any comments? |
@LaurenSpiegel I'm sorry, can you clarify what is the question for me? Do you mean my thoughts on the Batch Balancer-like discussion above? I would agree it seems the same motivation that there was at the time of implementing the batch balancer for Pre and Prove Commit seems to apply to this case: introduces a batching tool that makes gas usage for batches more efficient, but would need something like Batch Balancer to ensure this batching is only enabled when there is demand and it is needed. So a batch balancer seems reasonable (would have to carefully choose the parameters for a given goal). What would be even better would be more permanent solutions like Explicit proof fees @Kubuxu has been leading, but this project has been somewhat paused. The best case scenario would be to finish carrying through the explicit fees idea, including this case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
Assigning FIP-0082 to this. Please update the FIP metadata and filename, and add a link to this document in the root README. |
9983e2f
to
df81f12
Compare
* Add supersnap gas plots * Add min/max values for the numbers of aggregatable proofs * Center justify gas cost table
88d15fa
to
637f14f
Compare
Thanks for the approvals (all reviewers so far)! I'm unable to merge this, so I'll have to leave that to someone else if and when it's ready. |
No description provided.