Skip to content

Commit

Permalink
fix: increase MSRV
Browse files Browse the repository at this point in the history
The minimum supported Rust version is now 1.63, due to the tempfile
dependency.

Also fix/silence newly introduced Clippy warnings.
  • Loading branch information
vmx committed Sep 4, 2023
1 parent f46a0ce commit 8d85ef9
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
branches: master

env:
MSRV: 1.59.0
MSRV: 1.63.0
RUSTFLAGS: "-Dwarnings"
CARGO_INCREMENTAL: 0
RUST_BACKTRACE: 1
Expand Down
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ authors = ["dignifiedquire <[email protected]>"]
license = "MIT OR Apache-2.0"
edition = "2018"
resolver = "2"
rust-version = "1.59.0"
rust-version = "1.63.0"

description = "Aggregate BLS Signatures"
documentation = "https://docs.rs/bls-signatures"
Expand Down
4 changes: 3 additions & 1 deletion bls-signatures-ffi/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#![allow(clippy::missing_safety_doc)]

use std::slice::from_raw_parts;

#[cfg(feature = "pairing")]
Expand Down Expand Up @@ -86,7 +88,7 @@ pub unsafe extern "C" fn aggregate(

let signatures = try_ffi!(
parts
.map(|item| Signature::from_bytes(item))
.map(Signature::from_bytes)
.collect::<Result<Vec<_>, _>>(),
std::ptr::null_mut()
);
Expand Down
2 changes: 1 addition & 1 deletion rust-toolchain
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.59.0
1.63.0
4 changes: 2 additions & 2 deletions src/key.rs
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ use crate::signature::*;

pub(crate) const G1_COMPRESSED_SIZE: usize = 48;

#[derive(Debug, Copy, Clone, PartialEq)]
#[derive(Debug, Copy, Clone, Eq, PartialEq)]
pub struct PublicKey(pub(crate) G1Projective);

#[derive(Debug, Copy, Clone, PartialEq)]
#[derive(Debug, Copy, Clone, Eq, PartialEq)]
pub struct PrivateKey(pub(crate) Scalar);

impl From<G1Projective> for PublicKey {
Expand Down
2 changes: 1 addition & 1 deletion src/signature.rs
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ use crate::key::*;
const CSUITE: &[u8] = b"BLS_SIG_BLS12381G2_XMD:SHA-256_SSWU_RO_NUL_";
const G2_COMPRESSED_SIZE: usize = 96;

#[derive(Debug, Copy, Clone, PartialEq)]
#[derive(Debug, Copy, Clone, Eq, PartialEq)]
pub struct Signature(G2Affine);

impl From<G2Projective> for Signature {
Expand Down

0 comments on commit 8d85ef9

Please sign in to comment.