Replace the quadradic duplicate check logic with a linear version #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on #67. |
DrPeterVanNostrand
requested changes
Oct 20, 2023
DrPeterVanNostrand
approved these changes
Oct 20, 2023
It's ~2% slower with 10 hashes and ~2% faster with 100 hashes (with very noisy benchmarks). But the important part is that the runtime should scale linearly with the number of inputs. E.g., this version is 2.5x faster for 1000 signatures. fixes #68
Stebalien
force-pushed
the
steb/linear-dedup
branch
from
ffc88ec
to
4989969
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's ~2% slower with 10 hashes and ~2% faster with 100 hashes (with very noisy benchmarks). But the important part is that the runtime should scale linearly with the number of inputs. E.g., this version is 2.5x faster for 1000 signatures.
fixes #68