Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: zeorize support #75

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

palozano
Copy link

@palozano palozano commented Dec 11, 2023

This PR adds specific support for the Zeroize crate.

In particular, it allows the PrivateKey struct to derive Zeroize.

This translates into having the possibility to have secure PrivateKeys
since they won't leak any information if the memory address is accessed
after the variable is dropped.

The functionality relies on the fact that the crate bls12_381 also
implements Zeorize, so nothing in the API has changed.

Solves #74

@dignifiedquire
Copy link
Contributor

Looks like this doesn't actually compile yet. Given that zeroize is sth not everyone needs, I would also prefer this to be an optional feature.

@palozano
Copy link
Author

It does compile, but maybe you can indicate if there are some improvements in the code, @dignifiedquire

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants