-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show network name in binary versions #1642
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One correction but otherwise looks great 👍
Let's also revert changes to go.mod and go.sum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please also undo the changes to the yugabyte directory as they will conflict with #1648
Otherwise LGTM 👍
* feat: retrieve data served from multiple miners (#1578) * add booster-http multi-miner retrieve test (#1598) * feat: add booster-http multi-miner retrieve test * refactor: move api version check to its own function * test: add booster-bitswap multi-miner test (#1599) * multi-miner / single LID - piece doctor (#1600) * wip: multi-miner / 1 LID - piece doctor * refactor: move yugabyte migration details into a separate class * fix: add miner address to yugabyte / leveldb impl * refactor: update log in piece doctor no deals for miner to warning * refactor: break migration into two parts to avoid migrations bug * feat: skip set address in migration if PieceTracker table has no rows (#1614) * fix: split PieceTracker and PieceFlagged migrations (#1615) * fix: yugabyte migrate command name * Add miner address to top of page in boost UI (#1633) * feat: add miner address to top of page in boost UI * Update react/src/MinerAddress.js Co-authored-by: LexLuthr <[email protected]> --------- Co-authored-by: LexLuthr <[email protected]> * refactor: move StorageAccessApiInfo config into DealMaking at GraphsyncStorageAccessApiInfo (#1634) * Show list of retrieval miners on retrievals list page (#1637) * feat: show list of retrieval miners on retrievals list page * fix: retrieval miner address resolver * fix: mmlid fixes for LID UI (#1639) * fix: look up unseal status against multi-miner accessor (rather than just on local miner) (#1641) * Show warning on piece doctor page if still doing initial scan (#1643) * fix: look up unseal status against multi-miner accessor (rather than just on local miner) * feat: show warning on piece doctor page if still doing initial scan * Update extern/boostd-data/yugabyte/piecedoctor.go Co-authored-by: Anton Evangelatov <[email protected]> * Update extern/boostd-data/yugabyte/piecedoctor.go --------- Co-authored-by: Anton Evangelatov <[email protected]> * feat: change postgres timezone type to include timezone (#1645) * feat: show network name in binary versions (#1642) * fix boostd-data maddr, enhance build * add CQL migrator * refactor migrator * modify migrate query * remove idx from migrate query * remove CQL migrator * undo go mod changes, fix mainnet build * undo yugabyte changes * remove extra line * Cassandra migrations (#1648) * feat: cassandra migrations * refactor: dbname -> appliedMigration * fix: yugabyte lid test * feat: add postgres migration * refactor: simplify cassandra migrations * fix: delete duplicate rows in PieceTracker table * fix test --------- Co-authored-by: dirkmc <[email protected]> Co-authored-by: Anton Evangelatov <[email protected]>
Fixes #1623 partially
This PR enhances the build command to build with network name
I have seen multiple times where users build a binary for calibnet or devnet and then try to use it for mainnet. This is mostly due to the fact that we don't show the network name in the
--version
.