Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ivan/http private ip fix #1724

Merged
merged 5 commits into from
Sep 28, 2023
Merged

Ivan/http private ip fix #1724

merged 5 commits into from
Sep 28, 2023

Conversation

ischasny
Copy link
Collaborator

  • Don't allow download from private IP addresses by default. Add an option to drive that behaviour.
  • Don't follow http redirects.

dirkmc
dirkmc approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Nice work!

@ischasny ischasny merged commit dc7cdbe into ivan/http-transport-upgrades Sep 28, 2023
1 check passed
@ischasny ischasny deleted the ivan/http-security-fix branch September 28, 2023 16:05
@dirkmc dirkmc changed the title Ivan/http security fix Ivan/http private ip fix Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nonsense nonsense nonsense left review comments

@dirkmc dirkmc dirkmc approved these changes

@LexLuthr LexLuthr Awaiting requested review from LexLuthr

Assignees
No one assigned
Labels
None yet
Projects
Boost
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ischasny @nonsense @dirkmc