Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Curio market migration command #1967

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

LexLuthr
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaict this looks good


if !b {
// Add LID details to pieceDeal in HarmonyDB
_, err = hdb.Exec(ctx, `SELECT process_piece_deal($1, $2, $3, $4, $5, $6, $7, $8, $9)`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this will just reimport the piece, redoing LID/IPNI will be a separate small reindexing pipeline, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This is to ensure that there is no chance of missing metadata. Func process_piece_deal does not raise an exception if the piece is already present in the table. First time indexing task actually creates the indexes, we mark the piece as indexed and if another deal has the same piece then we skip the actual indexing next time around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants