This repository has been archived by the owner on Jan 3, 2023. It is now read-only.
New Eudico ordering interface #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## eudico #214 +/- ##
==========================================
+ Coverage 22.59% 22.65% +0.05%
==========================================
Files 609 609
Lines 66185 66210 +25
==========================================
+ Hits 14957 15002 +45
+ Misses 48549 48519 -30
- Partials 2679 2689 +10
|
matejpavlovic
approved these changes
Jun 27, 2022
| if err != nil { | ||
| log.With("epoch", nextEpoch). | ||
| Errorw("unable to push cross-messages", "error", err) | ||
| } | ||
|
|
||
| m.SubmitRequests(ctx, refs) |
There was a problem hiding this comment.
I realized that this is probably called a lot, as it is in the default branch of the select statement. It looks like it creates a sort of busy-wait loop, always burning up one CPU no matter what.
It's not a big deal for now though, as I expect this branch to be part of the request pool (mempool wrapper) module, where it we'll take this into account.
This is only a comment, no direct action required, so pls mark it directly as resolved yourself when you read it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an implementation of the interface - https://hackmd.io/6v00B72USpav6rDUUhqxAw - that was updated recently