Add proof aggregation API #169
Conversation
cryptonemo
force-pushed
the
feat-aggregation2
branch
from
fdabfe9
to
cee544c
Compare
cryptonemo
force-pushed
the
feat-aggregation2
branch
from
6417745
to
79d2c60
Compare
cryptonemo
force-pushed
the
feat-aggregation2
branch
from
240024d
to
6b0e09d
Compare
Note that there is still a crash bug on clean-up that needs to be resolved
cryptonemo
force-pushed
the
feat-aggregation2
branch
from
d3b301c
to
68614cf
Compare
| } | ||
|
|
||
| impl Drop for fil_AggregateProof { | ||
| fn drop(&mut self) { |
There was a problem hiding this comment.
I think this leaks the error_msg if there is one
There was a problem hiding this comment.
It's not allocated/managed, it just points to a rust string from the ffi toolkit as far as I know (similar to all other usages of the error_msg)
There was a problem hiding this comment.
If you implement Drop manually, you also need to drop error_msg. In other structs the #[derive(DropStructMacro)] implements Drop. Though in this case you can just use the DropStructMacro derive instead (see https://github.com/filecoin-project/rust-fil-ffi-toolkit/tree/master/drop-struct-macro-derive#readme for more information).
There was a problem hiding this comment.
Thanks, I see, will take a closer look. At one point, I may have needed to impl Drop rather than use the macro, but not sure that's the case any more.
magik6k
force-pushed
the
feat-aggregation2
branch
from
3bcefaf
to
f85e111
Compare
Signed-off-by: Jakub Sztandera <[email protected]>
style: rust fmt and clippy fixes
|
Requires filecoin-project/rust-fil-proofs#1395 and filecoin-project/rust-filecoin-proofs-api#51 and updated proofs releases before merging. |
|
Also requires: filecoin-project/rust-fil-ffi-toolkit#6 |
This PR is building on #166, so it's an alternative to it.