Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FileStore): CreateTemp accepts pattern used for file name #584

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(FileStore): CreateTemp accepts pattern used for file name #584

wants to merge 1 commit into from
+13 −7

Conversation

frrist
Copy link
Member

@frrist frrist commented Jul 21, 2021

@frrist frrist self-assigned this Jul 21, 2021
@frrist frrist mentioned this pull request Jul 23, 2021
Open
ribasushi
ribasushi approved these changes Jul 23, 2021
View reviewed changes
filestore/filestore.go Outdated
func (fs fileStore) CreateTemp() (File, error) {
f, err := ioutil.TempFile(fs.base, "fstmp")
func (fs fileStore) CreateTemp(pattern string) (File, error) {
if len(pattern) == 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: if pattern == "" is probably more idiomatic, but good to go as-is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ribasushi ribasushi ribasushi approved these changes

@dirkmc dirkmc Awaiting requested review from dirkmc

@hannahhoward hannahhoward Awaiting requested review from hannahhoward

At least 1 approving review is required to merge this pull request.

Assignees

@frrist frrist

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storage Provider creates informative names for deal data staged via the FileStore
2 participants
@frrist @ribasushi