-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIP 0027 integration #694
FIP 0027 integration #694
Conversation
@arajasek I can't tag you for it but need your review here |
|
Codecov Report
@@ Coverage Diff @@
## master #694 +/- ##
==========================================
+ Coverage 58.60% 58.74% +0.15%
==========================================
Files 64 64
Lines 5362 5390 +28
==========================================
+ Hits 3142 3166 +24
+ Misses 1882 1880 -2
- Partials 338 344 +6
|
Approve to all of @ZenGround0's commits! If someone can review the first commit and green check this, we can merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving this PR but I do have one non-blocking question.
There is a commented out test in storagemarket/impl/providerstates/provider_states_test.go.
Why is this test commented out? If it's no longer relevant let's remove it.
Thanks, this test is made irrelevant by the new label type which forbids invalidly long labels at the type level. Removing. |
Integrates a change to FIP-0027. o