chore: fail database tests if VISOR_TEST_DB not set (#79)

filecoin-project · Oct 8, 2020 · d22c545 · d22c545
1 parent 582fa77
commit d22c545
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 33 deletions.
diff --git a/storage/sql_test.go b/storage/sql_test.go
@@ -29,8 +29,8 @@ func TestNoDuplicateSchemaMigrations(t *testing.T) {
 }
 
 func TestSchemaIsCurrent(t *testing.T) {
-	if testing.Short() || !testutil.DatabaseAvailable() {
-		t.Skip("short testing requested or VISOR_TEST_DB not set")
+	if testing.Short() {
+		t.Skip("short testing requested")
 	}
 
 	ctx, cancel := context.WithTimeout(context.Background(), time.Second*5)
@@ -54,8 +54,8 @@ func TestSchemaIsCurrent(t *testing.T) {
 }
 
 func TestLeaseStateChanges(t *testing.T) {
-	if testing.Short() || !testutil.DatabaseAvailable() {
-		t.Skip("short testing requested or VISOR_TEST_DB not set")
+	if testing.Short() {
+		t.Skip("short testing requested")
 	}
 
 	ctx, cancel := context.WithTimeout(context.Background(), time.Second*5)
@@ -153,8 +153,8 @@ func TestLeaseStateChanges(t *testing.T) {
 }
 
 func TestMarkStateChangeComplete(t *testing.T) {
-	if testing.Short() || !testutil.DatabaseAvailable() {
-		t.Skip("short testing requested or VISOR_TEST_DB not set")
+	if testing.Short() {
+		t.Skip("short testing requested")
 	}
 
 	ctx, cancel := context.WithTimeout(context.Background(), time.Second*5)
@@ -248,8 +248,8 @@ func truncateVisorProcessingTables(tb testing.TB, db *pg.DB) {
 }
 
 func TestLeaseActors(t *testing.T) {
-	if testing.Short() || !testutil.DatabaseAvailable() {
-		t.Skip("short testing requested or VISOR_TEST_DB not set")
+	if testing.Short() {
+		t.Skip("short testing requested")
 	}
 
 	ctx, cancel := context.WithTimeout(context.Background(), time.Second*5)
@@ -356,8 +356,8 @@ func TestLeaseActors(t *testing.T) {
 }
 
 func TestMarkActorComplete(t *testing.T) {
-	if testing.Short() || !testutil.DatabaseAvailable() {
-		t.Skip("short testing requested or VISOR_TEST_DB not set")
+	if testing.Short() {
+		t.Skip("short testing requested")
 	}
 
 	ctx, cancel := context.WithTimeout(context.Background(), time.Second*5)
@@ -427,8 +427,8 @@ func TestMarkActorComplete(t *testing.T) {
 }
 
 func TestLeaseBlockMessages(t *testing.T) {
-	if testing.Short() || !testutil.DatabaseAvailable() {
-		t.Skip("short testing requested or VISOR_TEST_DB not set")
+	if testing.Short() {
+		t.Skip("short testing requested")
 	}
 
 	ctx, cancel := context.WithTimeout(context.Background(), time.Second*5)
@@ -526,8 +526,8 @@ func TestLeaseBlockMessages(t *testing.T) {
 }
 
 func TestMarkTipSetMessagesComplete(t *testing.T) {
-	if testing.Short() || !testutil.DatabaseAvailable() {
-		t.Skip("short testing requested or VISOR_TEST_DB not set")
+	if testing.Short() {
+		t.Skip("short testing requested")
 	}
 
 	ctx, cancel := context.WithTimeout(context.Background(), time.Second*5)
@@ -596,8 +596,8 @@ func TestMarkTipSetMessagesComplete(t *testing.T) {
 }
 
 func TestLeaseGasOutputsMessages(t *testing.T) {
-	if testing.Short() || !testutil.DatabaseAvailable() {
-		t.Skip("short testing requested or VISOR_TEST_DB not set")
+	if testing.Short() {
+		t.Skip("short testing requested")
 	}
 
 	ctx, cancel := context.WithTimeout(context.Background(), time.Second*5)
@@ -795,8 +795,8 @@ func TestLeaseGasOutputsMessages(t *testing.T) {
 }
 
 func TestMarkGasOutputsMessagesComplete(t *testing.T) {
-	if testing.Short() || !testutil.DatabaseAvailable() {
-		t.Skip("short testing requested or VISOR_TEST_DB not set")
+	if testing.Short() {
+		t.Skip("short testing requested")
 	}
 
 	ctx, cancel := context.WithTimeout(context.Background(), time.Second*5)

diff --git a/tasks/actorstate/genesis_test.go b/tasks/actorstate/genesis_test.go
@@ -39,8 +39,8 @@ func init() {
 }
 
 func TestGenesisProcessor(t *testing.T) {
-	if testing.Short() || !testutil.DatabaseAvailable() {
-		t.Skip("short testing requested or VISOR_TEST_DB not set")
+	if testing.Short() {
+		t.Skip("short testing requested")
 	}
 
 	ctx, cancel := context.WithTimeout(context.Background(), time.Second*30)
@@ -122,7 +122,6 @@ func TestGenesisProcessor(t *testing.T) {
 		require.NoError(t, err)
 		assert.NotEqual(t, 0, count)
 	})
-
 }
 
 // truncateGenesisTables ensures the indexing tables are empty

diff --git a/tasks/indexer/chainheadindexer_test.go b/tasks/indexer/chainheadindexer_test.go
@@ -42,8 +42,8 @@ func init() {
 }
 
 func TestChainHeadIndexer(t *testing.T) {
-	if testing.Short() || !testutil.DatabaseAvailable() {
-		t.Skip("short testing requested or VISOR_TEST_DB not set")
+	if testing.Short() {
+		t.Skip("short testing requested")
 	}
 
 	ctx, cancel := context.WithTimeout(context.Background(), time.Second*30)
@@ -159,7 +159,6 @@ func TestChainHeadIndexer(t *testing.T) {
 			assert.True(t, exists, "tsk: %s", tsk)
 		}
 	})
-
 }
 
 type blockHeaderList []*types.BlockHeader

diff --git a/tasks/indexer/chainhistoryindexer_test.go b/tasks/indexer/chainhistoryindexer_test.go
@@ -7,7 +7,6 @@ import (
 
 	apitest "github.com/filecoin-project/lotus/api/test"
 	nodetest "github.com/filecoin-project/lotus/node/test"
-	logging "github.com/ipfs/go-log/v2"
 
 	"github.com/go-pg/pg/v10"
 	"github.com/stretchr/testify/assert"
@@ -21,10 +20,8 @@ import (
 )
 
 func TestChainHistoryIndexer(t *testing.T) {
-	logging.SetLogLevel("*", "debug")
-
-	if testing.Short() || !testutil.DatabaseAvailable() {
-		t.Skip("short testing requested or VISOR_TEST_DB not set")
+	if testing.Short() {
+		t.Skip("short testing requested")
 	}
 
 	ctx, cancel := context.WithTimeout(context.Background(), time.Second*30)
@@ -136,5 +133,4 @@ func TestChainHistoryIndexer(t *testing.T) {
 			assert.True(t, exists, "tsk: %s", tsk)
 		}
 	})
-
 }
diff --git a/testutil/db.go b/testutil/db.go
@@ -28,7 +28,7 @@ func Database() string {
 // WaitForExclusiveDatabase waits for exclusive access to the test database until the context is done or the
 // exclusive access is granted. It returns a cleanup function that should be called to close the database connection.
 func WaitForExclusiveDatabase(ctx context.Context, tb testing.TB) (*pg.DB, func() error, error) {
-	require.NotEmpty(tb, testDatabase, "set VISOR_TEST_DB")
+	require.NotEmpty(tb, testDatabase, "No test database available: VISOR_TEST_DB not set")
 
 	opt, err := pg.ParseURL(testDatabase)
 	require.NoError(tb, err)
@@ -50,8 +50,10 @@ func WaitForExclusiveDatabase(ctx context.Context, tb testing.TB) (*pg.DB, func(
 	return db, cleanup, nil
 }
 
-const testDatabaseLockID = 88899888
-const testDatabaseLockCheckInterval = 2 * time.Millisecond
+const (
+	testDatabaseLockID            = 88899888
+	testDatabaseLockCheckInterval = 2 * time.Millisecond
+)
 
 // WaitForExclusiveDatabaseLock waits for a an exclusive lock on the test database until the context is done or the
 // exclusive access is granted. It returns a cleanup function that should be called to release the exclusive lock. In any