Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tipset worker to work with CSV storage #1029

Closed
frrist opened this issue Aug 8, 2022 · 1 comment · Fixed by #1035
Closed

Allow tipset worker to work with CSV storage #1029

frrist opened this issue Aug 8, 2022 · 1 comment · Fixed by #1035
Assignees
Labels
kind/bug Kind: Bug P1 P1: Must be resolved
Milestone

Comments

@frrist
Copy link
Member

frrist commented Aug 8, 2022

Describe the bug:

TODO @frrist
Currently, the tipsetwork only operates with a database as the storage output, it should also work with csv files.

Steps to Reproduce:

Lily Version: master

@frrist frrist added the kind/bug Kind: Bug label Aug 8, 2022
@frrist frrist self-assigned this Aug 8, 2022
@frrist frrist added the P1 P1: Must be resolved label Aug 8, 2022
@frrist
Copy link
Member Author

frrist commented Aug 9, 2022

This change will require a new GapFillWorker type to be implemented and some changes to the TipSetWorker. Currently, the TipSetWorker can handle watch, walk, index, and fill tasks. Since Fill tasks require writing to the DB (to mark gaps as filled) the TipSetWorker requires a Postgres database (transactional storage) to operate. We can instead do the following:

  1. Modify the TipSetWorker to only handle watch, walk, and index tasks. Removing the need to it to operate with transactional storage
  2. Implement a GapFillWorker that strictly handles fill tasks and require transactional storage with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Kind: Bug P1 P1: Must be resolved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant