Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name parameter to watch and walk jobs #452

Closed
iand opened this issue Apr 1, 2021 · 1 comment
Closed

Add name parameter to watch and walk jobs #452

iand opened this issue Apr 1, 2021 · 1 comment
Assignees
Labels
lily Related to the lily daemon

Comments

@iand
Copy link
Contributor

iand commented Apr 1, 2021

Description

It should be possible to name a job so it is easy for the user to identify the purpose of the job later.

Acceptance criteria

  • User can specify --name foo when starting a watch or walk job
  • The name is shown when the job list command is used
  • If a name is not specified a short unique one is generated, e.g. walk1

Where to begin

@iand iand added the lily Related to the lily daemon label Apr 1, 2021
@frrist frrist self-assigned this Apr 16, 2021
frrist added a commit that referenced this issue Apr 16, 2021
iand pushed a commit that referenced this issue Apr 19, 2021
@frrist
Copy link
Member

frrist commented Apr 19, 2021

closed via #467

@frrist frrist closed this as completed Apr 19, 2021
iand pushed a commit that referenced this issue Apr 20, 2021
…ply and revert events (#408)

chore: reuse watcher in lily watch command (#422)

Merge master into lily (#425)

* fix: ignore false positive gosec failure in wait package (#421)

* fix: embed genesis block in executable (#420)

* feat: add benchmarking of vectors (#423)

* feat: add benchmarking of vectors

* feat: add benchmarking of vectors

* Use nicer test and benchmark names

fix(linter): make deps before linting in CI (#437)

merge master into lily (#432)

* fix(indexer): only close TIpSetIndexer in walk and watch
* chore: increase linter timeout in ci

scheduler job control + watch, walk, and job cli (#414)

merge master into lily (#442)

* fix: ignore false positive gosec failure in wait package (#421)

* fix: embed genesis block in executable (#420)

* feat: add benchmarking of vectors (#423)

* feat: add benchmarking of vectors

* feat: add benchmarking of vectors

* Use nicer test and benchmark names

* Chore/sqlotus dag prefetch option (#430)

* Disable preloader by default, toggle with LOTUS_CHAINSTORE_PRELOAD_RECENTS

* Switch to a cli string as suggested by @iand

* Remove one more inefficiency for the R/O lens

filecoin-project/go-bs-postgres-chainnotated@b8b5d500e368d2ed

* Forgotten option/helptext spec

* Add support for static Get() prefetch

* close TipSetObs in walker and watcher

* fix(indexer): only close TIpSetIndexer in walk and watch

- subsequent calls to close will hang forever

* chore: increase linter timout in ci

* chore: update for Lotus 1.5.3 (#439)

* chore: update for Lotus 1.5.3

* fixup! chore: update for Lotus 1.5.3

* Update statediff version

Co-authored-by: frrist <[email protected]>

Co-authored-by: Ian Davis <[email protected]>
Co-authored-by: Peter Rabbitson <[email protected]>

chore: remove confidence argument from lily walk command (#444)

chore: reorganise visor commands (#445)

feat: add storage configuration to daemon (#446)

* feat: add storage configuration to daemon

* Start wiring up storage to config

* Finish wiring up storage config

* check error return when ensuring config

* Close config file on error

feat: Add --api parameter to daemon client commands (#450)

* feat: Add --api parameter to daemon client commands

* Make api default value a valid multiaddr

* Add api token parameter

Merge master into lily (#463)

* fix: ignore false positive gosec failure in wait package (#421)

* fix: embed genesis block in executable (#420)

* feat: add benchmarking of vectors (#423)

* feat: add benchmarking of vectors

* feat: add benchmarking of vectors

* Use nicer test and benchmark names

* Chore/sqlotus dag prefetch option (#430)

* Disable preloader by default, toggle with LOTUS_CHAINSTORE_PRELOAD_RECENTS

* Switch to a cli string as suggested by @iand

* Remove one more inefficiency for the R/O lens

filecoin-project/go-bs-postgres-chainnotated@b8b5d500e368d2ed

* Forgotten option/helptext spec

* Add support for static Get() prefetch

* close TipSetObs in walker and watcher

* fix(indexer): only close TIpSetIndexer in walk and watch

- subsequent calls to close will hang forever

* chore: increase linter timout in ci

* chore: update for Lotus 1.5.3 (#439)

* chore: update for Lotus 1.5.3

* fixup! chore: update for Lotus 1.5.3

* Update statediff version

Co-authored-by: frrist <[email protected]>

* Release notes for v0.5.5 (#440)

* chore: update lotus to 1.6.0 (#443)

* chore: upgrade lotus dependency to 1.6.0-rc1 (#447)

* chore: update lotus to 1.6.0 (#455)

* Release notes for v0.5.6 (#456)

* fix: ensure persistence semaphore channel is drained on close (#457)

* fix: ensure persistence semaphore channel is drained on close

* Add hidden window flag for testing

* Reduce actor happy path logging

* Make sure actor errors reported are appended to correct list

* Release notes for v0.5.7 (#458)

* Update to latest lotus commit

* Add missing support/tools/go.sum

* Fix merge bugs in makefile

* Fix merge bugs in makefile

Co-authored-by: Peter Rabbitson <[email protected]>
Co-authored-by: frrist <[email protected]>

feat: clean up command line flags for single-run jobs (#464)

* feat: clean up command line flags for single-run jobs
* Fix dockerfile

Co-authored-by: frrist <[email protected]>

polish(lily): add job name flag (#467)

- closes #452

polish(job): print job type, params, and errors in list (#468)

- closes #451

fix: ensure event channel is initialised before watch starts (#471)

chore: merge master into lily branch (#472)

* fix: ignore false positive gosec failure in wait package (#421)

* fix: embed genesis block in executable (#420)

* feat: add benchmarking of vectors (#423)

* feat: add benchmarking of vectors

* feat: add benchmarking of vectors

* Use nicer test and benchmark names

* Chore/sqlotus dag prefetch option (#430)

* Disable preloader by default, toggle with LOTUS_CHAINSTORE_PRELOAD_RECENTS

* Switch to a cli string as suggested by @iand

* Remove one more inefficiency for the R/O lens

filecoin-project/go-bs-postgres-chainnotated@b8b5d500e368d2ed

* Forgotten option/helptext spec

* Add support for static Get() prefetch

* close TipSetObs in walker and watcher

* fix(indexer): only close TIpSetIndexer in walk and watch

- subsequent calls to close will hang forever

* chore: increase linter timout in ci

* chore: update for Lotus 1.5.3 (#439)

* chore: update for Lotus 1.5.3

* fixup! chore: update for Lotus 1.5.3

* Update statediff version

Co-authored-by: frrist <[email protected]>

* Release notes for v0.5.5 (#440)

* chore: update lotus to 1.6.0 (#443)

* chore: upgrade lotus dependency to 1.6.0-rc1 (#447)

* chore: update lotus to 1.6.0 (#455)

* Release notes for v0.5.6 (#456)

* fix: ensure persistence semaphore channel is drained on close (#457)

* fix: ensure persistence semaphore channel is drained on close

* Add hidden window flag for testing

* Reduce actor happy path logging

* Make sure actor errors reported are appended to correct list

* Release notes for v0.5.7 (#458)

* fix(tasks): use correct ActorInfo for actor state extraction (#449)

* fix(tasks): use corret actor info for actor state extraction
- fixes #273

* fix(lens): remove OptimizedStateGetActorWithFallback
- fixes #405

* fix(market-task): fix market actor task and gen vector
- fixes #465

* polish(vector): support msapproval model validation

* test(vector): generate new test vectors

* ci: increase instance size due to test vectors

* Add MinerSectorInfo for extended sectors (#448)

Fixes #441. Extended sectors have new deadlines but this is not recorded anywhere.

* Fix makefile conflicts

Co-authored-by: Peter Rabbitson <[email protected]>
Co-authored-by: frrist <[email protected]>
Co-authored-by: Hector Sanjuan <[email protected]>
iand added a commit that referenced this issue Apr 20, 2021
* Create a Lily node by embedding lotus into visor to observe tipset apply and revert events (#408)

* chore: reuse watcher in lily watch command (#422)

* Merge master into lily (#425)

* fix: ignore false positive gosec failure in wait package (#421)

* fix: embed genesis block in executable (#420)

* feat: add benchmarking of vectors (#423)

* feat: add benchmarking of vectors

* feat: add benchmarking of vectors

* Use nicer test and benchmark names

* fix(linter): make deps before linting in CI (#437)

* merge master into lily (#432)

* fix(indexer): only close TIpSetIndexer in walk and watch
* chore: increase linter timeout in ci

* scheduler job control + watch, walk, and job cli (#414)

* merge master into lily (#442)

* fix: ignore false positive gosec failure in wait package (#421)

* fix: embed genesis block in executable (#420)

* feat: add benchmarking of vectors (#423)

* feat: add benchmarking of vectors

* feat: add benchmarking of vectors

* Use nicer test and benchmark names

* Chore/sqlotus dag prefetch option (#430)

* Disable preloader by default, toggle with LOTUS_CHAINSTORE_PRELOAD_RECENTS

* Switch to a cli string as suggested by @iand

* Remove one more inefficiency for the R/O lens

filecoin-project/go-bs-postgres-chainnotated@b8b5d500e368d2ed

* Forgotten option/helptext spec

* Add support for static Get() prefetch

* close TipSetObs in walker and watcher

* fix(indexer): only close TIpSetIndexer in walk and watch

- subsequent calls to close will hang forever

* chore: increase linter timout in ci

* chore: update for Lotus 1.5.3 (#439)

* chore: update for Lotus 1.5.3

* fixup! chore: update for Lotus 1.5.3

* Update statediff version

Co-authored-by: frrist <[email protected]>

Co-authored-by: Ian Davis <[email protected]>
Co-authored-by: Peter Rabbitson <[email protected]>

* chore: remove confidence argument from lily walk command (#444)

* chore: reorganise visor commands (#445)

* feat: add storage configuration to daemon (#446)

* feat: add storage configuration to daemon

* Start wiring up storage to config

* Finish wiring up storage config

* check error return when ensuring config

* Close config file on error

* feat: Add --api parameter to daemon client commands (#450)

* feat: Add --api parameter to daemon client commands

* Make api default value a valid multiaddr

* Add api token parameter

* Merge master into lily (#463)

* fix: ignore false positive gosec failure in wait package (#421)

* fix: embed genesis block in executable (#420)

* feat: add benchmarking of vectors (#423)

* feat: add benchmarking of vectors

* feat: add benchmarking of vectors

* Use nicer test and benchmark names

* Chore/sqlotus dag prefetch option (#430)

* Disable preloader by default, toggle with LOTUS_CHAINSTORE_PRELOAD_RECENTS

* Switch to a cli string as suggested by @iand

* Remove one more inefficiency for the R/O lens

filecoin-project/go-bs-postgres-chainnotated@b8b5d500e368d2ed

* Forgotten option/helptext spec

* Add support for static Get() prefetch

* close TipSetObs in walker and watcher

* fix(indexer): only close TIpSetIndexer in walk and watch

- subsequent calls to close will hang forever

* chore: increase linter timout in ci

* chore: update for Lotus 1.5.3 (#439)

* chore: update for Lotus 1.5.3

* fixup! chore: update for Lotus 1.5.3

* Update statediff version

Co-authored-by: frrist <[email protected]>

* Release notes for v0.5.5 (#440)

* chore: update lotus to 1.6.0 (#443)

* chore: upgrade lotus dependency to 1.6.0-rc1 (#447)

* chore: update lotus to 1.6.0 (#455)

* Release notes for v0.5.6 (#456)

* fix: ensure persistence semaphore channel is drained on close (#457)

* fix: ensure persistence semaphore channel is drained on close

* Add hidden window flag for testing

* Reduce actor happy path logging

* Make sure actor errors reported are appended to correct list

* Release notes for v0.5.7 (#458)

* Update to latest lotus commit

* Add missing support/tools/go.sum

* Fix merge bugs in makefile

* Fix merge bugs in makefile

Co-authored-by: Peter Rabbitson <[email protected]>
Co-authored-by: frrist <[email protected]>

* feat: clean up command line flags for single-run jobs (#464)

* feat: clean up command line flags for single-run jobs
* Fix dockerfile

Co-authored-by: frrist <[email protected]>

* polish(lily): add job name flag (#467)

- closes #452

* polish(job): print job type, params, and errors in list (#468)

- closes #451

* fix: ensure event channel is initialised before watch starts (#471)

* chore: merge master into lily branch (#472)

* fix: ignore false positive gosec failure in wait package (#421)

* fix: embed genesis block in executable (#420)

* feat: add benchmarking of vectors (#423)

* feat: add benchmarking of vectors

* feat: add benchmarking of vectors

* Use nicer test and benchmark names

* Chore/sqlotus dag prefetch option (#430)

* Disable preloader by default, toggle with LOTUS_CHAINSTORE_PRELOAD_RECENTS

* Switch to a cli string as suggested by @iand

* Remove one more inefficiency for the R/O lens

filecoin-project/go-bs-postgres-chainnotated@b8b5d500e368d2ed

* Forgotten option/helptext spec

* Add support for static Get() prefetch

* close TipSetObs in walker and watcher

* fix(indexer): only close TIpSetIndexer in walk and watch

- subsequent calls to close will hang forever

* chore: increase linter timout in ci

* chore: update for Lotus 1.5.3 (#439)

* chore: update for Lotus 1.5.3

* fixup! chore: update for Lotus 1.5.3

* Update statediff version

Co-authored-by: frrist <[email protected]>

* Release notes for v0.5.5 (#440)

* chore: update lotus to 1.6.0 (#443)

* chore: upgrade lotus dependency to 1.6.0-rc1 (#447)

* chore: update lotus to 1.6.0 (#455)

* Release notes for v0.5.6 (#456)

* fix: ensure persistence semaphore channel is drained on close (#457)

* fix: ensure persistence semaphore channel is drained on close

* Add hidden window flag for testing

* Reduce actor happy path logging

* Make sure actor errors reported are appended to correct list

* Release notes for v0.5.7 (#458)

* fix(tasks): use correct ActorInfo for actor state extraction (#449)

* fix(tasks): use corret actor info for actor state extraction
- fixes #273

* fix(lens): remove OptimizedStateGetActorWithFallback
- fixes #405

* fix(market-task): fix market actor task and gen vector
- fixes #465

* polish(vector): support msapproval model validation

* test(vector): generate new test vectors

* ci: increase instance size due to test vectors

* Add MinerSectorInfo for extended sectors (#448)

Fixes #441. Extended sectors have new deadlines but this is not recorded anywhere.

* Fix makefile conflicts

Co-authored-by: Peter Rabbitson <[email protected]>
Co-authored-by: frrist <[email protected]>
Co-authored-by: Hector Sanjuan <[email protected]>

Co-authored-by: Ian Davis <[email protected]>
Co-authored-by: Peter Rabbitson <[email protected]>
Co-authored-by: Hector Sanjuan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lily Related to the lily daemon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants