Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add height to tables without height #484

Closed
hsanjuan opened this issue Apr 21, 2021 · 3 comments · Fixed by #528
Closed

Add height to tables without height #484

hsanjuan opened this issue Apr 21, 2021 · 3 comments · Fixed by #528
Assignees
@hsanjuan

Comments

@hsanjuan
Copy link
Contributor

hsanjuan commented Apr 21, 2021 •
edited
Loading

Tracking all tables that need height:

  • id_addresses
  • chain_economics
@hsanjuan hsanjuan added this to the Schema-related issues before full backfill milestone Apr 28, 2021
@thattommyhall
Copy link

For the Parquet exports, it's nice to have something that can be related to a datetime, as well as id_addresses height is missing from chain_economics and there we have parent_state_root

@hsanjuan
Copy link
Contributor Author

hsanjuan commented May 6, 2021

We should have height in all tables

@hsanjuan hsanjuan changed the title Add height to id_addresses Add height to tables without height May 6, 2021
@thattommyhall
Copy link

I did go through all the existing schemas so I am pretty sure those 2 are all (tho the drand one is round, not height)

@hsanjuan hsanjuan self-assigned this May 21, 2021
hsanjuan added a commit that referenced this issue May 21, 2021
@hsanjuan
Fix #484: Add Height to IDAddress and ChainEconomics
806d4cd 
Fixes #484. These two tables are missing heights, which makes difficult to
partition exports.
@hsanjuan hsanjuan mentioned this issue May 21, 2021
Closed
@iand iand mentioned this issue May 26, 2021
Merged
@iand iand closed this as completed in #528 Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsanjuan hsanjuan

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@thattommyhall @hsanjuan