Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: walk test uses in memory storage #1000

Merged
merged 1 commit into from
Jun 28, 2022
Merged

chore: walk test uses in memory storage #1000

merged 1 commit into from
Jun 28, 2022

Conversation

frrist
Copy link
Member

@frrist frrist commented Jun 21, 2022

  • reduce the requirements for running test

I have noticed this test flakes sometimes. On the off chance this is a race condition within Postgres I have removed it as a dependency of the test opting to use an in-memory storage type instead.

- reduce the requirements for running test
@codecov-commenter
Copy link

Codecov Report

Merging #1000 (0ac6275) into master (e917f43) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1000   +/-   ##
======================================
  Coverage    35.3%   35.3%           
======================================
  Files          31      31           
  Lines        2090    2090           
======================================
  Hits          739     739           
  Misses       1266    1266           
  Partials       85      85           

@frrist frrist requested review from kasteph and placer14 June 21, 2022 15:03
@frrist frrist self-assigned this Jun 21, 2022
@kasteph
Copy link
Contributor

kasteph commented Jun 21, 2022

@frrist shouldn't one test for Postgres race conditions anyway? This test might actually be surfacing such an issue (which I think you've also brought up before).

@placer14
Copy link
Contributor

It would be good to understand the race condition a bit more, but I'm in favor of decoupling this from the DB state if we can use memory state instead regardless.

@frrist frrist merged commit 69dca22 into master Jun 28, 2022
@frrist frrist deleted the frrist/walked-test branch June 28, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants