Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove actor code mapping #1087

Merged
merged 3 commits into from
Nov 17, 2022
Merged

Conversation

birdychang
Copy link
Contributor

Without actor code mapping, MakeGetActorCodeFunc & all GetActorCode calls only take a few ms to execute.
Time to construct actor code mapping with 5M state store caching takes ~10s.
Time to construct actor code mapping without caching takes ~40s.

@codecov-commenter
Copy link

Codecov Report

Merging #1087 (9f9ccde) into master (85faa23) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1087   +/-   ##
======================================
  Coverage    34.3%   34.3%           
======================================
  Files          44      44           
  Lines        2932    2932           
======================================
  Hits         1008    1008           
  Misses       1828    1828           
  Partials       96      96           

lens/util/repo.go Outdated Show resolved Hide resolved
Copy link
Contributor

@kasteph kasteph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these should get rid of the linting errors.

lens/util/repo.go Outdated Show resolved Hide resolved
birdychang and others added 3 commits November 16, 2022 13:20
* refactor: polish GetActorCodeFunc
  - remove address resolution, its handled by lotus internally via state.GetActor
@birdychang birdychang merged commit d23f21c into master Nov 17, 2022
@birdychang birdychang deleted the birdy/remote-actor-code-map branch November 17, 2022 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants