chore(docker): Cache proof params in production docker image #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1101 +/- ##
======================================
Coverage 32.8% 32.8%
======================================
Files 46 46
Lines 3156 3156
======================================
Hits 1037 1037
Misses 2023 2023
Partials 96 96 |
|
The integration test appears to be a failure of IPFS and not the test itself. I will be unavailable to merge this over the break. Please merge at will. |
frrist
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/filecoin-project/sentinel-infra/issues/408
Note the tradeoff here is a larger image (going from ~300MB to ~700MB) in exchange for shorter startup time and avoidance of potential future issues related to transient proof downloads.
(This also means that proof changes will require a new build/release.)