fix: only parse vm messages with exit code OK

[frrist]

• closes Error failed parse child message params cid when walking vm_messages #1110

[birdychang]

lgtm

[kasteph]

Ty

[davidgasquez]

I've tested the changes locally and seems to work! No errors in grep ERROR visor_processing_reports.csv and all epochs have some vm_messages data:

$ cut -d, -f1 vm_messages.csv  | sort | uniq -c
   1730 185794
   1838 185795
   2021 185796
   1954 185797
   1676 185798
   1634 185799
   1846 185800
   1802 185801
   1561 185802
   1539 185803
   2041 185804

Found some errors in lily.log but I think they're unrelated.

$ grep error lily.log 
2023-01-13T10:32:03.454Z        WARN    dht/RtRefreshManager    rtrefresh/rt_refresh_manager.go:136     failed when refreshing routing table2 errors occurred:
2023-01-13T10:32:03.454Z        WARN    dht/RtRefreshManager    rtrefresh/rt_refresh_manager.go:199     failed when refreshing routing table    {"error": "2 errors occurred:\n\t* failed to query for self, err=failed to find any peer in table\n\t* failed to refresh cpl=0, err=failed to find any peer in table\n\n"}
2023-01-13T10:32:08.179Z        INFO    basichost       basic/natmgr.go:93      DiscoverNAT error:no NAT found
    See https://docs.rs/flexi_logger/latest/flexi_logger/error_info/index.html#time
2023-01-13T10:33:09.796Z        WARN    vm      vm/vm.go:535    Send actor error        {"from": "f3q2hdy5rpzmttcdm5l5y4mnou36qzdlobuaci3ospry3hco3utunkrb6lsvynyxbxekoy5vbdvibrxt3y6c3a", "to": "f02303", "nonce": 22482, "method": "7", "height": "185801", "error": "failed to submit proof for bulk verification (RetCode=7):\n    github.com/filecoin-project/specs-actors/v2/actors/builtin.RequireSuccess\n        /go/pkg/mod/github.com/filecoin-project/specs-actors/[email protected]/actors/builtin/shared.go:49"}
2023-01-13T10:33:09.814Z        WARN    vm      vm/vm.go:535    Send actor error        {"from": "f3q2hdy5rpzmttcdm5l5y4mnou36qzdlobuaci3ospry3hco3utunkrb6lsvynyxbxekoy5vbdvibrxt3y6c3a", "to": "f02303", "nonce": 22487, "method": "7", "height": "185801", "error": "failed to submit proof for bulk verification (RetCode=7):\n    github.com/filecoin-project/specs-actors/v2/actors/builtin.RequireSuccess\n        /go/pkg/mod/github.com/filecoin-project/specs-actors/[email protected]/actors/builtin/shared.go:49"}
2023-01-13T10:33:10.266Z        WARN    vm      vm/vm.go:535    Send actor error        {"from": "f3q2hdy5rpzmttcdm5l5y4mnou36qzdlobuaci3ospry3hco3utunkrb6lsvynyxbxekoy5vbdvibrxt3y6c3a", "to": "f02303", "nonce": 22488, "method": "7", "height": "185801", "error": "failed to submit proof for bulk verification (RetCode=7):\n    github.com/filecoin-project/specs-actors/v2/actors/builtin.RequireSuccess\n        /go/pkg/mod/github.com/filecoin-project/specs-actors/[email protected]/actors/builtin/shared.go:49"}
2023-01-13T10:33:10.272Z        WARN    vm      vm/vm.go:535    Send actor error        {"from": "f3q2hdy5rpzmttcdm5l5y4mnou36qzdlobuaci3ospry3hco3utunkrb6lsvynyxbxekoy5vbdvibrxt3y6c3a", "to": "f02303", "nonce": 22491, "method": "7", "height": "185801", "error": "failed to submit proof for bulk verification (RetCode=7):\n    github.com/filecoin-project/specs-actors/v2/actors/builtin.RequireSuccess\n        /go/pkg/mod/github.com/filecoin-project/specs-actors/[email protected]/actors/builtin/shared.go:49"}
2023-01-13T10:33:25.263Z        WARN    vm      vm/vm.go:535    Send actor error        {"from": "f3ra3fl2imvqoxecrdsavr4lvpemiwekelvu6wkdhf6kc6fjntokuuqzliakpfry7xnj7g4vqdzasa4wueoisa", "to": "f02626", "nonce": 3279, "method": "5", "height": "185800", "error": "cannot prove partitions with no active sectors (RetCode=16):\n    github.com/filecoin-project/specs-actors/v2/actors/builtin/miner.Actor.SubmitWindowedPoSt.func1\n        /go/pkg/mod/github.com/filecoin-project/specs-actors/[email protected]/actors/builtin/miner/miner_actor.go:480"}
2023-01-13T10:33:25.554Z        WARN    vm      vm/vm.go:535    Send actor error        {"from": "f3ra3fl2imvqoxecrdsavr4lvpemiwekelvu6wkdhf6kc6fjntokuuqzliakpfry7xnj7g4vqdzasa4wueoisa", "to": "f02626", "nonce": 3280, "method": "5", "height": "185800", "error": "cannot prove partitions with no active sectors (RetCode=16):\n    github.com/filecoin-project/specs-actors/v2/actors/builtin/miner.Actor.SubmitWindowedPoSt.func1\n        /go/pkg/mod/github.com/filecoin-project/specs-actors/[email protected]/actors/builtin/miner/miner_actor.go:480"}
2023-01-13T10:34:11.326Z        WARN    vm      vm/vm.go:535    Send actor error        {"from": "f3rdyag3qlqoecvi3ajnq4aidpywy2xpg47wrcphavlhrjbeyugujaqmxetrftzud6s3mhxljonwrth66j6mza", "to": "f053229", "nonce": 129242, "method": "7", "height": "185797", "error": "failed to submit proof for bulk verification (RetCode=7):\n    github.com/filecoin-project/specs-actors/v2/actors/builtin.RequireSuccess\n        /go/pkg/mod/github.com/filecoin-project/specs-actors/[email protected]/actors/builtin/shared.go:49"}
2023-01-13T10:34:30.142Z        WARN    vm      vm/vm.go:535    Send actor error        {"from": "f3uboypycwc7g4bxlbgylozin6v3qkfhurdrherli4463yckfacdeasxtsgcntpcv2pv65fpvbextdnsajzlja", "to": "f014569", "nonce": 1010, "method": "5", "height": "185796", "error": "cannot prove partitions with no active sectors (RetCode=16):\n    github.com/filecoin-project/specs-actors/v2/actors/builtin/miner.Actor.SubmitWindowedPoSt.func1\n        /go/pkg/mod/github.com/filecoin-project/specs-actors/[email protected]/actors/builtin/miner/miner_actor.go:480"}
2023-01-13T10:35:01.954Z        WARN    vm      vm/vm.go:535    Send actor error        {"from": "f3rdyag3qlqoecvi3ajnq4aidpywy2xpg47wrcphavlhrjbeyugujaqmxetrftzud6s3mhxljonwrth66j6mza", "to": "f053229", "nonce": 129219, "method": "7", "height": "185794", "error": "failed to submit proof for bulk verification (RetCode=7):\n    github.com/filecoin-project/specs-actors/v2/actors/builtin.RequireSuccess\n        /go/pkg/mod/github.com/filecoin-project/specs-actors/[email protected]/actors/builtin/shared.go:49"}
2023-01-13T10:42:03.455Z        WARN    dht/RtRefreshManager    rtrefresh/rt_refresh_manager.go:199     failed when refreshing routing table    {"error": "2 errors occurred:\n\t* failed to query for self, err=failed to find any peer in table\n\t* failed to refresh cpl=0, err=failed to find any peer in table\n\n"}

[kasteph]

Those NAT errors can be ignored, I think.

[frrist]

The vm/vm.go:535 Send actor error errors are benign. They are stating lily will not parse params for VM messages with non-zero exit codes.

[davidgasquez]

Thanks for the fix @frrist!