Frrist/receipt events schema #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
- track the value of EventRoots contained in message receipts.
frrist
force-pushed
the
frrist/receipt-events-schema
branch
from
e525fdd
to
be3f295
Compare
frrist
added a commit
that referenced
this pull request
Feb 16, 2023
* feat: implement actor event task and schema - track the value of EventRoots contained in message receipts.
Closed
|
Nice. |
raulk
reviewed
Feb 18, 2023
Comment on lines
+7
to
+19
| CREATE TABLE IF NOT EXISTS {{ .SchemaName | default "public"}}.actor_events ( | ||
| height bigint NOT NULL, | ||
| state_root text NOT NULL, | ||
| event_index bigint NOT NULL, | ||
| message_cid text NOT NULL, | ||
|
|
||
| emitter text NOT NULL, | ||
| flags bytea NOT NULL, | ||
| key text NOT NULL, | ||
| value bytea NOT NULL, | ||
|
|
||
| PRIMARY KEY ("height", "state_root", "event_index", "message_cid") | ||
| ); |
There was a problem hiding this comment.
@frrist is this tracking the new event schema which includes the codec? FIP-0049 was updated ~2 weeks ago to add a codec field (value 0x55, RAW) always.
There was a problem hiding this comment.
Will add the codec value shortly, missed that in my initial implementation. Thanks for the pointer!
raulk
reviewed
Feb 18, 2023
Comment on lines
+88
to
+92
| evtArr, err := amt.LoadAMT(ctx, t.node.Store(), *rec.EventsRoot, amt.UseTreeBitWidth(types.EventAMTBitwidth)) | ||
| if err != nil { | ||
| report.ErrorsDetected = fmt.Errorf("loading actor events amt (%s): %w", *rec.EventsRoot, err) | ||
| return nil, report, nil | ||
| } |
There was a problem hiding this comment.
If this is capable of using Lotus APIs, you can now invoke the ChainGetEvents JSON-RPC operation with the events root CID. It will do the AMT handling on the server side.
There was a problem hiding this comment.
Yup this has the full lotus API, in #1137 we call that instead, replacing the amt loading logic in this file with the lotus API method.
raulk
reviewed
Feb 18, 2023
| report.ErrorsDetected = fmt.Errorf("loading actor events amt (%s): %w", *rec.EventsRoot, err) | ||
| return nil, report, nil | ||
| } | ||
| var evt types.Event |
There was a problem hiding this comment.
Ah, if the dependencies are updated, this should already. be using the correct event schema (incl. codec). However, you might want to consider inserting the codec as well into the Lily table, although not a big deal since it's a fixed value 0x55 and we can always backfill once other values become possible.
frrist
added a commit
that referenced
this pull request
Feb 22, 2023
* feat: implement actor event task and schema - track the value of EventRoots contained in message receipts.
frrist
added a commit
that referenced
this pull request
Feb 22, 2023
Terryhung
pushed a commit
that referenced
this pull request
Mar 3, 2023
* feat: implement actor event task and schema - track the value of EventRoots contained in message receipts.
Terryhung
pushed a commit
that referenced
this pull request
Mar 3, 2023
birdychang
pushed a commit
that referenced
this pull request
Mar 8, 2023
* deps: update to lotus 1.20.0-rc2 * chore: update actor gen - clean up types, remove lily actors types, replace with go-state-types * Frrist/receipt events schema (#1132) * feat: implement actor event task and schema - track the value of EventRoots contained in message receipts. * feat: implement message param schema and task - create a table that records raw message parameters * feat: track raw receipt return value * fix schema index's after rebase on master * fix: use builtin lotus method to get events - it handles the case of legacy events * fixup! Frrist/receipt events schema (#1132) * deps: replace deprecated blocks package - use github.com/ipfs/go-libipfs/blocks instead * deps: update to v1.20.0 release * feat: track verifreg actor claim HAMT changes (#1141) * feat: track verified registry actor claim HAMT changes - addresses request made here: https://github.com/protocol/pldw/issues/177#issuecomment-1372920524 * fix: correctly diff new actor version (#1145) * fix: correctly diff new actor version - closes #1144 * chore: remove unused metrics * metric: track GettActorStateChanges duration * feat: update lotus deps to support vm para/ret marshal (#1150) - use lotus deps from filecoin-project/lotus#10372 * fix: resolve the duplication issue of db migration version --------- Co-authored-by: Terry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Produces the below table (example from hyperspace-net):