Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: metrics for state & block store caches #1136

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Conversation

frrist
Copy link
Member

@frrist frrist commented Feb 17, 2023

Gives us metrics like:

# HELP visor_state_store_cache_hits Number of cache hits for the state store cache
# TYPE visor_state_store_cache_hits counter
visor_state_store_cache_hits 8.774107e+06

# HELP visor_state_store_cache_limit Max size of cache
# TYPE visor_state_store_cache_limit gauge
visor_state_store_cache_limit 500000

# HELP visor_state_store_cache_read Number of reads from the state store cache
# TYPE visor_state_store_cache_read counter
visor_state_store_cache_read 1.7223509e+07

# HELP visor_state_store_cache_size Number of elements in the cache
# TYPE visor_state_store_cache_size gauge
visor_state_store_cache_size 500000

and

# HELP visor_block_store_cache_hits Number of cache hits for the block store cache
# TYPE visor_block_store_cache_hits counter
visor_block_store_cache_hits 254849

# HELP visor_block_store_cache_limit Max size of cache
# TYPE visor_block_store_cache_limit gauge
visor_block_store_cache_limit 500000

# HELP visor_block_store_cache_read Number of reads from the block store cache
# TYPE visor_block_store_cache_read counter
visor_block_store_cache_read 8.760208e+06

# HELP visor_block_store_cache_size Number of elements in the cache
# TYPE visor_block_store_cache_size gauge
visor_block_store_cache_size 500000

Copy link
Contributor

@birdychang birdychang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kasteph kasteph merged commit f42e6f3 into master Feb 17, 2023
@kasteph kasteph deleted the frrist/cache-metrics branch February 17, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants