feat: Add docker compose file for notifier and worker #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birdychang
requested changes
Feb 18, 2023
added 6 commits
February 18, 2023 17:27
frrist
reviewed
Feb 20, 2023
kasteph
suggested changes
Feb 20, 2023
|
why another |
kasteph
reviewed
Feb 28, 2023
kasteph
reviewed
Feb 28, 2023
|
|
||
| [Pubsub] | ||
| Bootstrapper = false | ||
| RemoteTracer = "/dns4/pubsub-tracer.filecoin.io/tcp/4001/p2p/QmTd6UvR47vUidRNZ1ZKXHrAFhqTJAD27rKL9XYghEKgKX" |
There was a problem hiding this comment.
This should be configured in our instance either via an environment variable or adding directly on the config.toml and not part of the general deployment definition.
There was a problem hiding this comment.
It's already the default? https://github.com/filecoin-project/lily/blob/master/config/config.go#L178
There was a problem hiding this comment.
I think it should also be removed out of that config. It seems like a forgotten hard-coded value.
birdychang
reviewed
Mar 2, 2023
This prometheus has it's docker compose file and it's config. |
Terryhung
changed the title
Terryhung
changed the title
Terryhung
changed the title
kasteph
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports user to deploy the notfier and worker independently.