Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not error on null or empty params for parsing message #1171

Merged
merged 2 commits into from
Mar 23, 2023
Merged

fix: do not error on null or empty params for parsing message #1171

merged 2 commits into from
Mar 23, 2023

Conversation

frrist
Copy link
Member

@frrist frrist commented Mar 23, 2023

No description provided.

@frrist frrist requested a review from birdychang March 23, 2023 01:51
@Terryhung Terryhung marked this pull request as ready for review March 23, 2023 08:15
birdychang
birdychang approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@birdychang birdychang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update pr title?

@Terryhung Terryhung changed the title too much commitment fix: do not error on null params Mar 23, 2023
@Terryhung Terryhung changed the title fix: do not error on null params fix: do not error on null params during parsing message Mar 23, 2023
@Terryhung Terryhung changed the title fix: do not error on null params during parsing message fix: do not error on null params for parsing message Mar 23, 2023
@Terryhung Terryhung changed the title fix: do not error on null params for parsing message fix: do not error on null or empty params for parsing message Mar 23, 2023
@Terryhung Terryhung merged commit f412bca into master Mar 23, 2023
@Terryhung Terryhung deleted the frrist/fix-empty-param-parse branch March 23, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birdychang birdychang birdychang approved these changes

Assignees

@Terryhung Terryhung

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frrist @birdychang @Terryhung