feat: add filter for actor changes #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
May 5, 2023 15:16
birdychang
approved these changes
May 8, 2023
tasks/actorstate/task.go
Outdated
| const defaultActorChangeLimit = 10000 | ||
|
|
||
| // Skip task processing when actor state changes abnormally. | ||
| func (t *Task) exceedActorChangeLimit(changes map[address.Address]tasks.ActorStateChange) bool { |
There was a problem hiding this comment.
nit: exceedsActorChangeLimit
kasteph
reviewed
May 8, 2023
.gitignore
Outdated
| @@ -21,3 +21,5 @@ visor | |||
| build/.* | |||
| support/tools/bin | |||
|
|
|||
| # Deployment | |||
| deployment/.env | |||
There was a problem hiding this comment.
Suggested change
| deployment/.env | |
| .env |
There was a problem hiding this comment.
We will put the .env file in the deployment folder because of docker-compose usage, therefore we should add the gitignore here 😄 .
There was a problem hiding this comment.
I change it to *.env.
There was a problem hiding this comment.
Simply doing .env would ignore it in all paths instead of *.env which would only ignore in the root path. If we do hyperspecific paths like so, we could face the same problem again where the secrets are revealed.
tasks/actorstate/task.go
Outdated
| limit := defaultActorChangeLimit | ||
|
|
||
| // Access the custom threshold set in the environment variable | ||
| s := os.Getenv(actorChangeLimiterEnv) |
There was a problem hiding this comment.
Suggested change
| s := os.Getenv(actorChangeLimiterEnv) | |
| s := os.Getenv(actorChangeLimiterEnv) |
os.LookupEnv might be nicer.
kasteph
suggested changes
May 9, 2023
birdychang
approved these changes
May 11, 2023
kasteph
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature can help prevent this issue from occurring again.
By modifying the environment variable:
LILY_ACTOR_CHANGE_LIMITER, it is able to adjust the threshold.