Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CodeCID should be at end of model #1205

Merged
merged 1 commit into from
May 16, 2023
Merged

Conversation

kasteph
Copy link
Contributor

@kasteph kasteph commented May 16, 2023

CSVs produced follow the order of the definition in the model. So CSVs of actors produced with this model definition are ordered like so:

height,id,state_root,code,code_cid,head,balance,nonce,state

This is problematic when inserting CSVs to other data sources as one then has to create these two columns before the change is introduced and fill these null values manually (really only a problem for code_cid which is in the middle of the table).

Note that Postgres doesn't have this issue (new columns are appended at the end).

Copy link
Contributor

@birdychang birdychang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kasteph kasteph merged commit 7e61323 into master May 16, 2023
@kasteph kasteph deleted the kasteph/add-codecid-to-end branch May 16, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants