Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: keep running the whole tipset task without cancel #1219

Merged
merged 3 commits into from
Jun 6, 2023
Merged

fix: keep running the whole tipset task without cancel #1219

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c142e4a
Keep running the whole tipset task without cancel
Jun 5, 2023
8ae4ac2
put the error to report ErrorsDetected
Jun 6, 2023
0ad4923
Add error to errordetected
Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion chain/indexer/integrated/tipset/tipset.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,6 @@ func (ti *TipSetIndexer) TipSet(ctx context.Context, ts *types.TipSet) (chan *Re
if res.Error != nil {
llt.Errorw("task returned with error", "error", res.Error.Error())
errCh <- res.Error
return
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we continue to execute, will ErrorsDetected be populated so the task report will show the reason?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it would be populated

}
// processor is complete if we receive a result
executingTasks[res.Task] = true
Expand Down