fix: run more backfill tipsetkey during import chain #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 6, 2023 14:08
birdychang
approved these changes
Jun 6, 2023
commands/init.go
Outdated
| Name: "backfill-tipsetkey-range", | ||
| Usage: "Determine the extent of backfilling from the head.", | ||
| EnvVars: []string{"LILY_BACKFILL_TIPSETKEY_RANGE"}, | ||
| Value: 1800, |
There was a problem hiding this comment.
our snapshot range is 2890 epochs. Should we make the default something like 3000 or 3600 to ensure we always backfill more than a day?
commands/util/import.go
Outdated
| @@ -189,6 +190,11 @@ func ImportChain(ctx context.Context, r repo.Repo, fname string, snapshot bool) | |||
| return fmt.Errorf("importing chain failed: %w", err) | |||
| } | |||
|
|
|||
| err = backfillMoreEpochsForTipsetKey(ctx, ts, cst, backfillTipsetkeyRange) | |||
There was a problem hiding this comment.
Add comment to explain cst.Import() only backfills 1800 epochs.
Make the name shorter backfillTipsetKey .
There was a problem hiding this comment.
added more comment!
birdychang
approved these changes
Jun 6, 2023
commands/util/import.go
Outdated
| @@ -189,6 +190,14 @@ func ImportChain(ctx context.Context, r repo.Repo, fname string, snapshot bool) | |||
| return fmt.Errorf("importing chain failed: %w", err) | |||
| } | |||
|
|
|||
| // The cst.Import function will only backfill 1800 epochs of tipsetkey, | |||
| // as determined by the value specified in TipsetkeyBackfillRange. | |||
There was a problem hiding this comment.
this line might be confusing since we have backfillTipsetKeyRange. No need to mention the variable in cst.import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.