Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: var names for chain commands #1236

Merged
merged 1 commit into from
Jun 26, 2023
Merged

fix: var names for chain commands #1236

merged 1 commit into from
Jun 26, 2023

Conversation

kasteph
Copy link
Contributor

@kasteph kasteph commented Jun 23, 2023

closes #1224

@kasteph kasteph requested a review from Terryhung June 23, 2023 23:59
birdychang
birdychang approved these changes Jun 24, 2023
View reviewed changes
Copy link
Contributor

@birdychang birdychang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@kasteph kasteph merged commit a71342b into master Jun 26, 2023
@kasteph kasteph deleted the kasteph/fix-var-names branch June 26, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birdychang birdychang birdychang approved these changes

@Terryhung Terryhung Awaiting requested review from Terryhung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

These two variable names in the source code need to be swapped. ChainStateComputeRange and ChainStateCompute.
2 participants
@kasteph @birdychang