-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add Transform implementation for PreCommitInfoExtractorV8 #1242
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Thanks for the fix! |
63d8187
to
051dbd1
Compare
case "ARRAY": | ||
datatype = "bigint[]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of this: https://github.com/filecoin-project/lily/blob/master/storage/sql_test.go#L49 -- it's a convenience function being used in such a test.
Moreover, the mapping of data types between Postgres and Golang is not one-to-one that's why the original code has this condition as well because it tries to equate a Postgres datatype with a fld.SQLType
here
@@ -449,19 +449,28 @@ func MakeProcessors(api tasks.DataSource, indexerTasks []string) (*IndexerProces | |||
), | |||
minertask.LockedFundsExtractor{}, | |||
) | |||
case tasktype.MinerPreCommitInfoV1_8: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This is much better.
For earlier parts of the chain, i.e. when miner actors were v8 and below, we get the following error: