Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add changelog generator #199

Merged
merged 2 commits into from
Nov 4, 2020
Merged

feat: add changelog generator #199

merged 2 commits into from
Nov 4, 2020

Conversation

placer14
Copy link
Contributor

@placer14 placer14 commented Nov 3, 2020

Here's something we might use to refine our changelog generation for releases going forward. Intend to use this for our next release.

@placer14 placer14 requested review from iand and frrist November 3, 2020 20:37

.PHONY: changelog
changelog:
git-chglog -o CHANGELOG.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this binary to make deps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'd be good with that.

CHANGELOG.md Outdated
### Build
- add prometheus, grafana and dashboard images

### Chore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to change the ordering so that breaking changes, features and fixes are first?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely. The template is completely configurable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second look, it appears the struct for managing this will not allow custom sorting. Others appear to have wanted this feature so it's probably easy to apply here but the project appears to be abandoned. Though I do like the template-based configuration. Would we object to pulling this wierd commit in the deps and including the custom sort option as shown in khos2ow/git-chglog@df30eea?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we agree to handle the sorting manually right now for this release and circle back to resolve afterward?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's fine. We could also fork git-chglog and apply that sort patch.

@placer14 placer14 changed the title feat: add changelog generator Release v0.3.0 Nov 4, 2020
@placer14 placer14 changed the title Release v0.3.0 feat: add changelog generator Nov 4, 2020
@placer14 placer14 merged commit 3a3aaf6 into master Nov 4, 2020
@placer14 placer14 deleted the mg/changelog-generator branch November 4, 2020 18:00
placer14 added a commit that referenced this pull request Nov 4, 2020
 By Ian Davis (25) and others
 Via GitHub
 origin/master: (66 commits)
  feat: add changelog generator (#199)
  feat: disable leasing when gas outputs lease time is zero (#198)
  feat: add power actor claim extraction
  chore: Include RC releases in push docker images (#195)
  fix(metrics): export the completion and batch selection views (#197)
  fix: fix actor completion query
  chore: add metrics to leasing and work completion queries
  continue message parsing task when cbor parse fails (#185)
  perf: ensure processing updates always include height in criteria (#192)
  perf: include height restrictions in update clauses of leasing queries (#189)
  open lotusrepo lens read only
  feat: allow actor state processor to run without leasing (#178)
  feat: rpc reconnection on failure (#149)
  chore: add changelog (#150)
  polish: update miner processing logic
  feat: add dynamic panel creation based on tags (#159)
  don't codeql on every commit to pr. only on PR merge and cron (#168)
  track statechange persist duration
  feat: add dynamic panel creation based on tags
  Replace filecoin-ffi with stubs to simplify build process (#166)
  ...

Conflicts:
	commands/run.go

 It looks like you may be committing a merge.
 If this is not correct, please remove the file
	/Users/mg/work/pl/sentinel/.git/modules/sentinel-visor/MERGE_HEAD
 and try again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants