fix: csv output handles time and interface values #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
placer14
reviewed
Jan 13, 2021
storage/csv.go
Outdated
| // Special formatting for known types | ||
| if ft.PkgPath() == "time" && ft.Name() == "Time" { | ||
| v := fv.Interface().(time.Time) | ||
| row[i] = v.Format("2006-01-02T15:04:05.999Z07:00") |
There was a problem hiding this comment.
Suggested change
| row[i] = v.Format("2006-01-02T15:04:05.999Z07:00") | |
| row[i] = v.Format(PostgresTimestampFormat) |
| @@ -169,10 +173,29 @@ func (c *CSVBatch) PersistModel(ctx context.Context, m interface{}) error { | |||
| for i, f := range t.fields { | |||
| fv := value.FieldByName(f) | |||
| fk := fv.Kind() | |||
| if (fk == reflect.Slice || fk == reflect.Map || fk == reflect.Ptr || fk == reflect.Chan || fk == reflect.Func) && fv.IsNil() { | |||
| if (fk == reflect.Slice || fk == reflect.Map || fk == reflect.Ptr || fk == reflect.Chan || fk == reflect.Func || fk == reflect.Interface) && fv.IsNil() { | |||
There was a problem hiding this comment.
nit: Worth breaking these into seaparate lines?
There was a problem hiding this comment.
I don't think it would add much to readability. Besides, we all have screen resolutions beyons 640x480 😀
| require.NoError(t, err) | ||
| assert.EqualValues(t, | ||
| "height,value\n"+ | ||
| "42,\"[{\"\"Source\"\":\"\"some task\"\",\"\"Error\"\":{}}]\"\n", |
There was a problem hiding this comment.
This assertion does not match the Error contained in tm.
frrist
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.