-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to lotus 1.5.0-pre1 and actors v3 #371
Conversation
673ea54
to
d79fb3a
Compare
Codecov Report
@@ Coverage Diff @@
## master #371 +/- ##
======================================
Coverage 43.0% 43.1%
======================================
Files 25 25
Lines 1917 1932 +15
======================================
+ Hits 826 833 +7
- Misses 964 972 +8
Partials 127 127 |
d79fb3a
to
a8b28d6
Compare
a8b28d6
to
e5fd69e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confused how the ffi-stub
was building before the types or constants were present. I don't see where it was changed but checking out locally it obviously points to that module. Just some small confusion, but looks good otherwise. 🤝
@@ -41,7 +43,7 @@ func TestRewardExtractV0(t *testing.T) { | |||
stateCid, err := mapi.Store().Put(ctx, state) | |||
require.NoError(t, err) | |||
|
|||
minerAddr := tutils.NewIDAddr(t, 00) | |||
minerAddr := tutils.NewIDAddr(t, 0o0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be nothing, but curious why this was needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not my doing. I think gofumpt does it. Numbers starting with 0 are octal in Go, and they added 0o
as a consistent way to write them to match 0x
only the subset of ffi stub actually referenced by us or lotus is needed when a module replacement happens. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🙏
ℹ️ There is a dependency on statediff for parsing message parameters. that may also need to get pulled up to the v3 dependencies to continue functioning. I expect to do that this week. |
They were in the real ffi package but not imported into Lotus until recently. |
Tests for actors v3 are copy/paste of v2 tests with fixups for the types. The main change for v3 is the structure of the HAMT.