Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make default docker image name deterministic #390

Merged
merged 1 commit into from
Feb 18, 2021
Merged

chore: make default docker image name deterministic #390

merged 1 commit into from
Feb 18, 2021

Conversation

placer14
Copy link
Contributor

@placer14 placer14 commented Feb 17, 2021 •
edited
Loading

Minor adjustments:

  • increase default SHA length to 8 chars
  • include truncated SHA as part of tag name for all master docker images
  • cleanup unused behavior in docker build script

The name adjustments are to support automated deployments of master branch with versioned tags.

@placer14 placer14 force-pushed the mg/chore/fix-docker-build-names branch 5 times, most recently from 8d5485e to 3e14932 Compare February 18, 2021 02:34
@placer14 placer14 force-pushed the mg/chore/fix-docker-build-names branch from 3e14932 to 9dc3f37 Compare February 18, 2021 02:46
@placer14 placer14 marked this pull request as ready for review February 18, 2021 02:49
@placer14 placer14 requested review from frrist and iand February 18, 2021 02:49
@iand iand merged commit 625a7cc into master Feb 18, 2021
@iand iand deleted the mg/chore/fix-docker-build-names branch February 18, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iand iand iand approved these changes

@frrist frrist Awaiting requested review from frrist

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@placer14 @iand