Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): restore semver build; correct names; simplify build pipeline #393

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

placer14
Copy link
Contributor

@placer14 placer14 commented Feb 18, 2021

This PR includes fixes to further support the automatic deployment pipeline work. Specifically:

  • Simplify docker build pipeline and scripts (remove GIT_BRANCH case; isolate workflow commands)
  • Fix docker image name (remove extraneous -dev on image name)
  • Restore semver publishing behavior (trigger was removed in prior PR)
  • Fix semver dev image labeled as production
  • Fix step names to be understandable in CircleCI UI

Proof of work:
These images were actually pushed to docker hub if you'd like to test them out:
Dev builds have bin/bash shell for entrypoint: docker run -it --rm --entrypoint=/bin/bash filecoin/sentinel-visor:v0.0.0-rc0-dev
Prod builds have bin/sh shell for entrypoint: docker run -it --rm --entrypoint=/bin/sh filecoin/sentinel-visor:v0.0.0-rc0

@placer14 placer14 force-pushed the mg/fix/docker-build-destination branch 5 times, most recently from 8296c47 to 8173168 Compare February 19, 2021 16:46
@placer14 placer14 marked this pull request as ready for review February 19, 2021 16:48
@placer14 placer14 requested a review from iand February 19, 2021 16:49
@placer14 placer14 force-pushed the mg/fix/docker-build-destination branch from 8173168 to 9a59ac4 Compare February 19, 2021 16:55
@codecov-io
Copy link

Codecov Report

Merging #393 (9a59ac4) into master (625a7cc) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #393   +/-   ##
======================================
  Coverage    46.4%   46.4%           
======================================
  Files          24      24           
  Lines        1796    1796           
======================================
  Hits          835     835           
  Misses        834     834           
  Partials      127     127           

@placer14 placer14 force-pushed the mg/fix/docker-build-destination branch from 9a59ac4 to b1c9873 Compare February 19, 2021 17:04
@placer14 placer14 changed the title fix: correct docker image name; simplify build pipeline fix(docker): restore semver build; correct names; simplify build pipeline Feb 19, 2021
@placer14 placer14 added the kind/bug Kind: Bug label Feb 19, 2021
@iand iand merged commit 8bec4ae into master Feb 22, 2021
@iand iand deleted the mg/fix/docker-build-destination branch February 22, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Kind: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants