feat(genesis): Add task for processing genesis state #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 16, 2020
iand
reviewed
Sep 17, 2020
| case builtin.VerifiedRegistryActorCodeID: | ||
| // TODO | ||
| default: | ||
| return fmt.Errorf("unknown actor in genesis state. address: %s code: %s head: %s", addr, genesisAct.Code, genesisAct.Head) |
There was a problem hiding this comment.
Seems drastic to abort just because we have an unknown actor. Maybe log and continue.
| } | ||
| } | ||
| return &genesismodel.GenesisMinerTaskResult{ | ||
| stateModel, |
There was a problem hiding this comment.
Use field names here otherwise this will break if we add a field
frrist
force-pushed
the
frrist/genesis-task
branch
from
4a0e996
to
7a288c1
Compare
- only handles miner state, as more models are added the genesis task processing logic will need to be extended to include new models in the genesis state. special handling is required here since *most* task processing work by comparing the state of actors across two tipsets, since there isn't a tipset before the genesis block we need special handling.
frrist
force-pushed
the
frrist/genesis-task
branch
from
7a288c1
to
c94c7f7
Compare
|
@iand I have addressed the feedback and rebased onto master, this is ready for another look when you are available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only handles miner state, as more models are added the genesis task
processing logic will need to be extended to include new models in the
genesis state.
special handling is required here since most task processing works by
comparing the state of actors across two tipsets, since there isn't a
tipset before the genesis block we need special handling.
to follow #7