lotusrepo lens #90
Merged
lotusrepo lens #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ribasushi
reviewed
Oct 12, 2020
| "github.com/filecoin-project/specs-actors/actors/util/adt" | ||
| "github.com/ipfs/go-cid" | ||
| blockstore "github.com/ipfs/go-ipfs-blockstore" |
There was a problem hiding this comment.
Wrong blockstore:
https://godoc.org/github.com/filecoin-project/lotus/lib/blockstore
There was a problem hiding this comment.
the definition an alias type though, right?
There was a problem hiding this comment.
I didn't dig hat you pulled: you might have just grabbed aliases and it is fine. But for future-self...
placer14
added a commit
that referenced
this pull request
Oct 14, 2020
* origin/master: feat: Add historical indexer metrics (#92) fix(lens): Include dependencies needed for Repo Lens (#90) Move migration to schema version 10 fix(migrations): migrations require version 0 feat: add message gas economy processing perf(db): reduce batch size for chain history indexer (#105) fix: use hash index type for visor_processing_actors_code_idx (#106) feat: set application name in postgres connection (#104) feat: add visor processing stats table (#96) feat(task): add chain economics processing (#94) get actor name for both versions of specs-actors (#101)
placer14
added a commit
that referenced
this pull request
Oct 14, 2020
…-view * origin/master: feat: Add miner_sector_posts tracking of window posts (#74) feat: Add historical indexer metrics (#92) fix(lens): Include dependencies needed for Repo Lens (#90) Move migration to schema version 10 fix(migrations): migrations require version 0 feat: add message gas economy processing perf(db): reduce batch size for chain history indexer (#105) fix: use hash index type for visor_processing_actors_code_idx (#106) feat: set application name in postgres connection (#104) feat: add visor processing stats table (#96) feat(task): add chain economics processing (#94) get actor name for both versions of specs-actors (#101) fix: remove errgrp from UnindexedBlockData persist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change switches the repo lens to directly create a chainstore, rather than spinning up a full internal lotus node. This (per @ribasushi) should be lighter weight.
Need to audit usage of the lens to see if other modules than the chain one are used and need to also be filled in.
fix #88