test: Implement unit testing for miner sector deals extraction #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frrist
commented
Jun 18, 2022
| @@ -0,0 +1,677 @@ | |||
| // Code generated by mockery v0.0.0-dev. DO NOT EDIT. | |||
There was a problem hiding this comment.
Code generate mocks for the miner state interface as it's quite large.
| @@ -275,6 +276,10 @@ func (t *DataSource) ExecutedAndBlockMessages(ctx context.Context, ts, pts *type | |||
| return value.(*lens.TipSetMessages), nil | |||
| } | |||
|
|
|||
| func (t *DataSource) MinerLoad(store adt.Store, act *types.Actor) (miner.State, error) { | |||
There was a problem hiding this comment.
Move the logic responsible for loading miners from the blockstore to an interface allowing tests to use mocked miner state for validation.
| @@ -14,6 +14,7 @@ import ( | |||
| "github.com/filecoin-project/lily/chain/indexer/integrated/tipset" | |||
| "github.com/filecoin-project/lily/model" | |||
| visormodel "github.com/filecoin-project/lily/model/visor" | |||
| "github.com/filecoin-project/lily/testutil" | |||
There was a problem hiding this comment.
mechanical change: package rename
| "github.com/filecoin-project/lily/tasks/actorstate" | ||
| ) | ||
|
|
||
| type State interface { |
There was a problem hiding this comment.
The state type used by miner extractors. Presents a (mockable) interface for gathering miner data for extraction
| return ExtractSectorDealsModel(ctx, ec) | ||
| } | ||
|
|
||
| func ExtractSectorDealsModel(ctx context.Context, ec extraction.State) (minermodel.MinerSectorDealList, error) { |
There was a problem hiding this comment.
Move the model extraction logic to a testable method. extraction.State is an interface we can mock.
frrist
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR:
SectorDealsExtractorandLoadMinerStatesmethods.SectorDealsExtractorto improve its testability by moving the extraction logic to a new method -ExtractSectorDealsModel- which accepts interfaces that may be mocked to mimic a miners state.MinerLoadon theDataSourceAPI permitting the miner extractors to load mocked miner states for easier testing.