Fix random test failures

If block 1 was a null block then blockSet would include genesis which would lead to us trying to load parent of a genesis block. Signed-off-by: Jakub Sztandera <[email protected]>
filecoin-project · Oct 23, 2020 · 16a911b · 16a911b
1 parent c81db5a
commit 16a911b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/chain/sync.go b/chain/sync.go
@@ -1396,6 +1396,11 @@ loop:
 	}
 
 	base := blockSet[len(blockSet)-1]
+	if base.Equals(known) {
+		blockSet = blockSet[:len(blockSet)-1]
+		base = blockSet[len(blockSet)-1]
+	}
+
 	if base.IsChildOf(known) {
 		// common case: receiving blocks that are building on top of our best tipset
 		return blockSet, nil

diff --git a/miner/miner.go b/miner/miner.go
@@ -280,7 +280,7 @@ minerLoop:
 			m.minedBlockHeights.Add(blkKey, true)
 
 			if err := m.api.SyncSubmitBlock(ctx, b); err != nil {
-				log.Errorf("failed to submit newly mined block: %s", err)
+				log.Errorf("failed to submit newly mined block: %+v", err)
 			}
 		} else {
 			base.NullRounds++