Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated Linters Causing failed checks #11967

Closed
rjan90 opened this issue May 6, 2024 · 2 comments · Fixed by #11968
Closed

Deprecated Linters Causing failed checks #11967

rjan90 opened this issue May 6, 2024 · 2 comments · Fixed by #11968

Comments

@rjan90
Copy link
Contributor

rjan90 commented May 6, 2024

During the execution of golangci-lint when submitting a PR, several linters are reported as deprecated and fully inactivated, causing the process to fail. It suggest that we:

  • Replace varcheck with unused.
  • Replace deadcode with unused.
  • Replace scopelint with exportloopref.
  • Replace golint with revive.
@rvagg
Copy link
Member

rvagg commented May 7, 2024

Some context, latest update turned deprecation of these into an error, see section 5 in https://golangci-lint.run/product/changelog/#1580

varcheck and deadcode recommended replacement with unused here: https://golangci-lint.run/product/changelog/#v1490

discussion on scopelint: golangci/golangci-lint#1041 - exportloopref and looppointer come up here, but looppointer was rejected @ golangci/golangci-lint#1924

revive mentioned as drop-in replacement to golint: https://golangci-lint.run/usage/linters/#revive

unfortunately revive is quite a bit pickier than golint and throws up a bunch of errors when implementing, so we'll have to fix up a bunch of problems

rvagg added a commit that referenced this issue May 7, 2024
@rvagg
chore: lint: update linter settings, fix lint errors
42720b8 
Ref: #11967
@rvagg rvagg mentioned this issue May 7, 2024
Merged
@rvagg
Copy link
Member

rvagg commented May 7, 2024

#11968 an attempt at what it might take .. a lot, without global exclusions

rvagg added a commit that referenced this issue May 9, 2024
@rvagg
chore: lint: fix lint errors with new linting config
c90a099 
Ref: #11967
rvagg added a commit that referenced this issue May 9, 2024
@rvagg
chore: lint: fix lint errors with new linting config
72070ce 
Ref: #11967
@rjan90 rjan90 linked a pull request May 9, 2024 that will close this issue
chore: lint: update linter settings, fix lint errors #11968
Merged
rvagg added a commit that referenced this issue May 13, 2024
@rvagg
chore: lint: fix lint errors with new linting config
40bda37 
Ref: #11967
rvagg added a commit that referenced this issue May 13, 2024
@rvagg
chore: lint: fix lint errors with new linting config
26d3fd2 
Ref: #11967
rjan90 pushed a commit that referenced this issue May 24, 2024
@rvagg @rjan90
chore: lint: fix lint errors with new linting config
a49d433 
Ref: #11967
magik6k pushed a commit to filecoin-project/curio that referenced this issue May 26, 2024
@rvagg @rjan90
chore: lint: fix lint errors with new linting config
c00d423 
Ref: filecoin-project/lotus#11967
magik6k pushed a commit to filecoin-project/curio that referenced this issue May 27, 2024
@rvagg @rjan90
chore: lint: fix lint errors with new linting config
5212883 
Ref: filecoin-project/lotus#11967
magik6k pushed a commit to filecoin-project/curio that referenced this issue May 27, 2024
@rvagg
chore: lint: fix lint errors with new linting config
23b17f2 
Ref: filecoin-project/lotus#11967
magik6k pushed a commit to filecoin-project/curio that referenced this issue May 27, 2024
@rvagg @rjan90
chore: lint: fix lint errors with new linting config
bc97ec9 
Ref: filecoin-project/lotus#11967
rjan90 added a commit that referenced this issue Jun 10, 2024
@rjan90 @rvagg
@Stebalien @smagdali @aarshkshah1992 @galargh
chore: releases: merge releases branch to master (#12076)
06f8fdc 
* release: v1.26.3 (#11908) (#11915)

* deps: update dependencies to address migration memory bloat

to address memory concerns during a heavy migration

Ref: filecoin-project/go-state-types#260
Ref: whyrusleeping/cbor-gen#96
Ref: filecoin-project/go-amt-ipld#90

* release: prep v1.26.3 patch

Prep v1.26.3 patch release:
- Update changelog, version and make gen + make docsgen-cli

* deps: update cbor-gen to tagged version

deps: update cbor-gen to tagged version

* deps: update go-state-types to tagged version

deps: update go-state-types to tagged version v0.13.2

* chore: deps: update go-state-types to v0.13.3

Fixes a panic when we have fewer than 1k proposals.

---------

Co-authored-by: Rod Vagg <[email protected]>
Co-authored-by: Steven Allen <[email protected]>

* build: release: v1.27.0-rc1 (#11947)

* chore: Set version as v1.27.0-rc1

Set version as v1.27.0-rc1, run make gen & make docsgen-cli

* Update changelog

Update changelog

* Update changelog

Update changelog based on feedback

* Bump pubsub-dep

Bump pubsub-dep

* Prep v1.27.0-rc2

Prep v1.27.0-rc2

* Typo fixes, and more changelog updates

Typo fixes, and more changelog updates

* chore: remove unmaintained bootstrappers (#11983)

* chore: remove unmaintained bootstrappers

chore: remove unmaintained bootstrappers

* Update mainnet.pi fixing typoed domain

fixing typo for 1475.io 'bootstarp' -> 'bootstrap'

* Update mainnet.pi

apparently the actual hostname is typoed. so bootstarp it is.

---------

Co-authored-by: smagdali <[email protected]>

* chore: update go-data-transfer and go-graphsync

* add ETH addrs API to Gateway (#11979)

* fix: copy Flags field from SectorOnChainInfo

Fixes: #11962

* feat: libp2p: Lotus stream cleanup (#11993)

* set stream deadlines in Lotus

* reduce timeout

* whitelist bootstrappers

* fix tests

* Update changelog and version

Update changelog and version

* ci: deprecate circle ci in favour of github actions (#11786)

* Update changelog

Update changelog with the deprecate circle-ci

* chore: update drand (#12021)

* Update changelog / make docsgen

Update changelog / make docsgen

* chore: lint: update golangci lint config

* remove and replace some linters
* remove some exclusions
* make all exclusions more explicit matches

* chore: lint: fix lint errors with new linting config

Ref: #11967

* chore: lint: address feedback from reviews

* doc: eth: restore comment lost in linter cleanup

Ref: #11968

* chore: libp2p: update to v0.34.1 (#12027)

* update libp2p to v0.34.0

* fix libp2p err

* fix imports

* update go mod

* update go mod

* Update changelog

Update changelog

* go mod tidy

go mod tidy

* revert go version change (#12050)

* Update changelog

Update changelog

* chore: backport #12054 to release/v1.27.0 branch (#12056)

* chore: pin golanglint-ci to v1.58.2 (#12054)

Fixes: #12044

* Add backport to changelog

Add backport to changelog

---------

Co-authored-by: Rod Vagg <[email protected]>

* Fix where #12054 is placed in changelog

Fix where #12054 is placed in changelog

* Add trailing line in Makefile

Add trailing line in Makefile

* Go mod tidy

Go mod tidy

---------

Co-authored-by: Rod Vagg <[email protected]>
Co-authored-by: Steven Allen <[email protected]>
Co-authored-by: smagdali <[email protected]>
Co-authored-by: Aarsh Shah <[email protected]>
Co-authored-by: Piotr Galar <[email protected]>
jennijuju added a commit that referenced this issue Jun 25, 2024
@jennijuju @rjan90
@rvagg @Stebalien @smagdali @aarshkshah1992 @galargh @ribasushi
chore: merge releases back to master (v1.27.1) (#12141)
4abdbef 
* release: v1.26.3 (#11908) (#11915)

* deps: update dependencies to address migration memory bloat

to address memory concerns during a heavy migration

Ref: filecoin-project/go-state-types#260
Ref: whyrusleeping/cbor-gen#96
Ref: filecoin-project/go-amt-ipld#90

* release: prep v1.26.3 patch

Prep v1.26.3 patch release:
- Update changelog, version and make gen + make docsgen-cli

* deps: update cbor-gen to tagged version

deps: update cbor-gen to tagged version

* deps: update go-state-types to tagged version

deps: update go-state-types to tagged version v0.13.2

* chore: deps: update go-state-types to v0.13.3

Fixes a panic when we have fewer than 1k proposals.

---------

Co-authored-by: Rod Vagg <[email protected]>
Co-authored-by: Steven Allen <[email protected]>

* build: release: v1.27.0-rc1 (#11947)

* chore: Set version as v1.27.0-rc1

Set version as v1.27.0-rc1, run make gen & make docsgen-cli

* Update changelog

Update changelog

* Update changelog

Update changelog based on feedback

* Bump pubsub-dep

Bump pubsub-dep

* Prep v1.27.0-rc2

Prep v1.27.0-rc2

* Typo fixes, and more changelog updates

Typo fixes, and more changelog updates

* chore: remove unmaintained bootstrappers (#11983)

* chore: remove unmaintained bootstrappers

chore: remove unmaintained bootstrappers

* Update mainnet.pi fixing typoed domain

fixing typo for 1475.io 'bootstarp' -> 'bootstrap'

* Update mainnet.pi

apparently the actual hostname is typoed. so bootstarp it is.

---------

Co-authored-by: smagdali <[email protected]>

* chore: update go-data-transfer and go-graphsync

* add ETH addrs API to Gateway (#11979)

* fix: copy Flags field from SectorOnChainInfo

Fixes: #11962

* feat: libp2p: Lotus stream cleanup (#11993)

* set stream deadlines in Lotus

* reduce timeout

* whitelist bootstrappers

* fix tests

* Update changelog and version

Update changelog and version

* ci: deprecate circle ci in favour of github actions (#11786)

* Update changelog

Update changelog with the deprecate circle-ci

* chore: update drand (#12021)

* Update changelog / make docsgen

Update changelog / make docsgen

* chore: lint: update golangci lint config

* remove and replace some linters
* remove some exclusions
* make all exclusions more explicit matches

* chore: lint: fix lint errors with new linting config

Ref: #11967

* chore: lint: address feedback from reviews

* doc: eth: restore comment lost in linter cleanup

Ref: #11968

* chore: libp2p: update to v0.34.1 (#12027)

* update libp2p to v0.34.0

* fix libp2p err

* fix imports

* update go mod

* update go mod

* Update changelog

Update changelog

* go mod tidy

go mod tidy

* revert go version change (#12050)

* Update changelog

Update changelog

* chore: backport #12054 to release/v1.27.0 branch (#12056)

* chore: pin golanglint-ci to v1.58.2 (#12054)

Fixes: #12044

* Add backport to changelog

Add backport to changelog

---------

Co-authored-by: Rod Vagg <[email protected]>

* Bump version - make gen/make docsgen

Bump version - make gen/make docsgen

* Update changelog

Update changelog

* Bump NodeBuildVersion to v1.27.1-rc1

Bump NodeBuildVersion to v1.27.1-rc1

* Add Lotus-Miner / Curio related changes

Add Lotus-Miner / Curio related changes

* Update date and upgrade warnings

Update date and upgrade warnings

* fix: ci: do not use deprecated --debug goreleaser flag (#12086)

* chore: deals: remove forgotten graphsync references (#12084)

* chore: types: remove more items forgotten after markets (#12095)

* chore: cleanup: remove more items forgotten after markets

* .gz somehow reappeared after #11625

* fix: ETH RPC API: ETH Call should use the parent state root of the subsequent tipset (#11905)

* fix eth call

* tests

* changes as per review

* changes as per review

* Update node/impl/full/eth.go

Co-authored-by: Rod Vagg <[email protected]>

* fix as per review

---------

Co-authored-by: Rod Vagg <[email protected]>

* Update changelog to RC2

Update changelog to RC2

* Make gen / make docsgen-cli

Make gen / make docsgen-cli

* chore: api: the Net API/CLI now remains only on daemon

The only part of this repository that does lp2p is now lotus-daemon

Remove the CommonNet type, used exclusively bu the CLI stack

Adjust the rest of struct-memebership to match what went where

End result best seen in diff of `documentation/en/api-v0-methods-miner.md`

* Update changelog

Update changelog

* fix: events: sqlite db improvements (#12090)

* fix: events: sqlite db improvements

* fix unclosed multi-row query
* tune options to limit wal growth

Ref: #12089

* fix: events: use correct context for CollectEvents transaction

* fix: events: close prepared read statement

* fix: events: close initial query; handle lint failures

* Update CHANGELOG.md

* build: release: v1.27.1-rc2 (#12101)

* fix: ci: do not use deprecated --debug goreleaser flag (#12086)

* chore: deals: remove forgotten graphsync references (#12084)

* chore: types: remove more items forgotten after markets (#12095)

* chore: cleanup: remove more items forgotten after markets

* .gz somehow reappeared after #11625

* fix: ETH RPC API: ETH Call should use the parent state root of the subsequent tipset (#11905)

* fix eth call

* tests

* changes as per review

* changes as per review

* Update node/impl/full/eth.go

Co-authored-by: Rod Vagg <[email protected]>

* fix as per review

---------

Co-authored-by: Rod Vagg <[email protected]>

* Update changelog to RC2

Update changelog to RC2

* Make gen / make docsgen-cli

Make gen / make docsgen-cli

* chore: api: the Net API/CLI now remains only on daemon

The only part of this repository that does lp2p is now lotus-daemon

Remove the CommonNet type, used exclusively bu the CLI stack

Adjust the rest of struct-memebership to match what went where

End result best seen in diff of `documentation/en/api-v0-methods-miner.md`

* Update changelog

Update changelog

* fix: events: sqlite db improvements (#12090)

* fix: events: sqlite db improvements

* fix unclosed multi-row query
* tune options to limit wal growth

Ref: #12089

* fix: events: use correct context for CollectEvents transaction

* fix: events: close prepared read statement

* fix: events: close initial query; handle lint failures

* Update CHANGELOG.md

---------

Co-authored-by: Piotr Galar <[email protected]>
Co-authored-by: Peter Rabbitson <[email protected]>
Co-authored-by: Aarsh Shah <[email protected]>
Co-authored-by: Rod Vagg <[email protected]>
Co-authored-by: Peter Rabbitson <[email protected]>

* small fix in changelog

* fix: release: update goreleaser config file

Fixes: #12120

* fix go releaser and test with rc3

* Update CHANGELOG.md

* lotus v1.27.1 prep

* address review
- resolve one more conflicts
- revert 2 new line added

* doc: events: note events db migration impact

---------

Co-authored-by: Phi-rjan <[email protected]>
Co-authored-by: Rod Vagg <[email protected]>
Co-authored-by: Steven Allen <[email protected]>
Co-authored-by: smagdali <[email protected]>
Co-authored-by: Aarsh Shah <[email protected]>
Co-authored-by: Piotr Galar <[email protected]>
Co-authored-by: Peter Rabbitson <[email protected]>
Co-authored-by: Peter Rabbitson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
FilOz
Status: ☑️ Done (Archive)
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: lint: update linter settings, fix lint errors filecoin-project/lotus
2 participants
@rvagg @rjan90