Expose control over deal decision logic

[whyrusleeping]

We need to expose some controls for the storage miner over their deal decision logic. Namely, we should be able to configure some parameters about deal auto acceptance, setting an ask is already there, but some additional things we need are:

• Ability to halt deal making (storage or retrieval independently) [ P0 ]
• Ability to decline deals if overloaded (requires feedback from storage-miner code) [ P1 ] #6750
• Ability to decline all deals matching certain criteria (offline deals, for example) [ P1 ]
• Ability to manually decide on certain deals (offline deals, for example) #6751

[whyrusleeping]

Additionally, we should allow miners to have a list of content CIDs they won't store or serve retrieval requests for. This may be required for miners to comply with local law enforcement requests (note that which lists to respect and which items to block are entirely up to the miner operator)

[laser]

Notes

This PR in go-fil-markets (now merged) adds a configuration option to the retrieval provider which allows the node to register a DealDecider, which is essentially a predicate to run on any ProviderDealState for purposes of accepting/rejecting a retrieval proposal.

There exists an equivalent bit of software for the storage provider, too.

[laser]

Also: I am working on Ability to halt deal making (storage or retrieval independently) [ P0 ] now.

This PR needs merging first. merged

[arajasek]

Hmm, for the CLI, I'd propose having a single command, call it selection (or a better name). It takes one input parameter, that can be "accept", "reject", or "manual". It also takes a series of flags, such as --offline. It can also take a --all, which would trigger all the options.

So, something like ./lotus-storage-miner market selection reject --offline would set us to reject all offline deals, while ./lotus-storage-miner market selection manual --all would set all incoming deals to need to be manually approved / rejected.

This would require some overhaul of the work in #1994, but not too much. Very much scope to be improved, I'm sure.

[laser]

Additionally, we should allow miners to have a list of content CIDs they won't store or serve retrieval requests for. This may be required for miners to comply with local law enforcement requests (note that which lists to respect and which items to block are entirely up to the miner operator)

Note: This has been addressed in this yet-to-be-merged PR. merged

[laser]

@arajasek

Manipulating config

Hmm, for the CLI, I'd propose having a single command, call it selection (or a better name).

I tweaked your proposal a little in hopes of making the various states straightforward (I eliminated the --all flag). To illustrate a potential UX, here's a table containing sequences of commands as well as the system's response to (after the commands have been run) receiving a storage deal proposal:

Note	Command Seq.	Offline Deal	Online Deal
1	./lotus-storage-miner market selection reset	consider	consider
	./lotus-storage-miner market selection reject --online	consider	reject
	./lotus-storage-miner market selection reject --offline	reject	consider
	./lotus-storage-miner market selection reject --offline ./lotus-storage-miner market selection reject --online	reject	reject
	./lotus-storage-miner market selection reject --offline ./lotus-storage-miner market selection manual --online	reject	manual
	./lotus-storage-miner market selection reject --online ./lotus-storage-miner market selection manual --offline	manual	reject
	./lotus-storage-miner market selection manual --online ./lotus-storage-miner market selection manual --offline	manual	manual
2	./lotus-storage-miner market selection manual --online ./lotus-storage-miner market selection reject --online	consider	reject
2	./lotus-storage-miner market selection reject --online ./lotus-storage-miner market selection manual --online	consider	manual

1: The selection reset command reverts the storage miner to the "consider all storage proposals" (default) state.
2. The second command wins.

Reading config

We'll also need a ./lotus-storage-miner market selection show command:

./lotus-storage-miner market selection show
offline deals: manual
online deals: reject

./lotus-storage-miner market selection show
offline deals: consider
online deals: manual

[arajasek]

@laser Yup, this sounds totally good to me! Thank youuuu :)

[TippyFlitsUK]

Hi @whyrusleeping

This issue has not been updated in some time. Should we close it or keep it open?

[github-actions]

Oops, seems like we needed more information for this issue, please comment with more details or this issue will be closed in 24 hours.

[github-actions]

This issue was closed because it is missing author input.