allow miner to disable/enable consideration of received storage deal proposals #1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes incremental progress towards #1920.
Storage miners, by default, should be configured to accept storage deals.
whyrusleeping
approved these changes
Jun 15, 2020
There was a problem hiding this comment.
Seems like a good pattern, will wait for @magik6k to also give a thumbs up as 'the DI guy'
arajasek
approved these changes
Jun 15, 2020
magik6k
approved these changes
Jun 15, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why does this PR exist?
This changeset makes incremental progress towards #1920.
What's in this PR?
This PR adds a
Configget/set pair to the DI graph for the newAcceptingStorageDealProposalbool. The getter always loads config TOML from disk, and is called by the storage deal provider when it receives a storage deal proposal. The setter is called through two new CLI commands:lotus-storage-miner deals disableandlotus-storage-miner deals enable.By default, a storage miner is configured to accept storage deals.