Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show help menu when lotus-miner actor set-addrs is called without argument #4857

Closed
karalabe opened this issue Nov 14, 2020 · 0 comments · Fixed by #5943
Closed

Show help menu when lotus-miner actor set-addrs is called without argument #4857

karalabe opened this issue Nov 14, 2020 · 0 comments · Fixed by #5943
Labels
area/ux Area: UX dif/easy An existing lotus user should be able to pick this up effort/hours Effort: Hours good first issue Good for newcomers kind/bug Kind: Bug P2 P2: Should be resolved

Comments

@karalabe
Copy link
Contributor

Most lotus commands print a help screen if no argument is provided. The lotus-miner actor set-addrs does not, rather instantly drops a transaction on chain that sets the address to nil. I'd say this is probably not what a user wants to do :)
@dineshshenoy dineshshenoy added effort/hours Effort: Hours and removed effort/minutes labels Nov 16, 2020
@jennijuju jennijuju changed the title lotus-miner actor set-addrs without argument nuked the address Show help menu when lotus-miner actor set-addrs is called Jan 19, 2021
@jennijuju jennijuju added good first issue Good for newcomers dif/easy An existing lotus user should be able to pick this up labels Jan 19, 2021
@jennijuju jennijuju changed the title Show help menu when lotus-miner actor set-addrs is called Show help menu when lotus-miner actor set-addrs is called without argument Jan 19, 2021
@jennijuju jennijuju added P2 P2: Should be resolved P3 P3: Might get resolved and removed P3 P3: Might get resolved labels Mar 24, 2021
@deaswang deaswang mentioned this issue Apr 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ux Area: UX dif/easy An existing lotus user should be able to pick this up effort/hours Effort: Hours good first issue Good for newcomers kind/bug Kind: Bug P2 P2: Should be resolved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix 4857: show help for set-addrs filcloud/lotus-mirror
3 participants
@karalabe @dineshshenoy @jennijuju