Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 4857: show help for set-addrs #5943

Merged
merged 3 commits into from
Apr 10, 2021
Merged

fix 4857: show help for set-addrs #5943

merged 3 commits into from
Apr 10, 2021

Conversation

deaswang
Copy link
Contributor

@deaswang deaswang commented Apr 2, 2021

fix #4857

arajasek
arajasek reviewed Apr 5, 2021
View reviewed changes
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the initiative! I have one question / suggestion.

@deaswang deaswang requested a review from arajasek April 6, 2021 03:25
arajasek
arajasek approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with Magik's suggested change

@magik6k
Copy link
Contributor

magik6k commented Apr 10, 2021

Thanks!

@magik6k magik6k merged commit 1e6bba5 into filecoin-project:master Apr 10, 2021
@magik6k magik6k mentioned this pull request Apr 13, 2021
Closed
69 tasks
@deaswang deaswang deleted the 4857-set-addrs branch April 22, 2021 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@arajasek arajasek arajasek approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show help menu when lotus-miner actor set-addrs is called without argument
3 participants
@deaswang @magik6k @arajasek